-
Couldn't load subscription status.
- Fork 576
Graduate flux from experiment folder to core torchtitan #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some comments.
|
could you also rebase onto #1871 |
Sure, will rebase later |
26ef236 to
3f607a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Thanks for the refactor! Had some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more logical organization of files, you think we can put clip and t5 config.json into tests/assets/flux_test_encoders/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to rebase onto #1851
FLUX.1 model is a diffusion model, which is different from language models and needs to extend train.py as needed.
train.pyandrun_train.sh, I kept a copy ofrun_tests()instead of generalizingintegration_tests/run_test.py