[simplefsdp] fix & enable DSV3 manual bucketing #2080
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
ruisizhang123
force-pushed
the
ruisi/fix_manual_bucketing_dsv3
branch
from
f931aa9 to
88b700b
Compare
ruisizhang123
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
ruisizhang123
commented
Dec 11, 2025
| ), | ||
| "16B": DeepSeekV3ModelArgs( | ||
| vocab_size=102400, | ||
| dim=2048, |
Member
Author
There was a problem hiding this comment.
@tianyu-l Should we have another config to allow users to turn on/off flexattention? Currently, flexattention doesn't work well with AC here. cc. @soulitzer for AC issue follow up!
Contributor
There was a problem hiding this comment.
what was the symptom?
also if it doesn't work why do we add an entry for it -- is it for repro?
tianyu-l
reviewed
Dec 11, 2025
| for m in modules: | ||
| if isinstance(m, list): | ||
| result.append(convert_modules_to_fqns(m, module_to_fqn_mapping)) | ||
| if fqn_list := convert_modules_to_fqns(m, module_to_fqn_mapping): |
Contributor
There was a problem hiding this comment.
what does the syntax mean -- assigning to fqn_list and check not None? It feels a bit unusual to read.
Also please add a comment on why we need this check
| ), | ||
| "16B": DeepSeekV3ModelArgs( | ||
| vocab_size=102400, | ||
| dim=2048, |
Contributor
There was a problem hiding this comment.
what was the symptom?
also if it doesn't work why do we add an entry for it -- is it for repro?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate DSV3 manual bucketing when EP/TP are enable. Tested on DSV3-16B model. Dependent on Pytorch PR
(Single Node: BS = 1)