(torchx/entrypoints) Use importlib.metadata instead of the backported importlib_metadata #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 2 commits into main from export-D77619564

Jul 3, 2025

Contributor

kiukchung commented Jul 1, 2025

Summary: torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported importlib_metadata module to load configurations from entry_points.

Differential Revision: D77619564

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

facebook-github-bot added the fb-exported label

facebook-github-bot pushed a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

761b911

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

facebook-github-bot force-pushed the export-D77619564 branch from 1bb16db to 761b911 Compare

July 1, 2025 23:18

Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

bc4db49

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from 761b911 to bc4db49 Compare

July 1, 2025 23:21

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

691a3be

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from bc4db49 to 691a3be Compare

July 1, 2025 23:22

Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

34cb426

… importlib_metadata (#1087)

Summary:
Pull Request resolved: #1087

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from 691a3be to 34cb426 Compare

July 1, 2025 23:25

andywag approved these changes

View reviewed changes

Contributor

andywag left a comment

lgtm

facebook-github-bot pushed a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

3f3d5ab

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

facebook-github-bot force-pushed the export-D77619564 branch from 34cb426 to 3f3d5ab Compare

July 1, 2025 23:34

Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

9657ac5

… importlib_metadata (#1087)

Summary:
Pull Request resolved: #1087

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from 3f3d5ab to 9657ac5 Compare

July 1, 2025 23:34

Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

highker approved these changes

View reviewed changes

facebook-github-bot pushed a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

facebook-github-bot force-pushed the export-D77619564 branch from 9657ac5 to 3385908 Compare

July 1, 2025 23:36

Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

facebook-github-bot pushed a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

08e5478

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

facebook-github-bot force-pushed the export-D77619564 branch from 3385908 to 08e5478 Compare

July 2, 2025 03:00

Contributor

facebook-github-bot commented Jul 2, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

facebook-github-bot pushed a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

e2721c7

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

facebook-github-bot force-pushed the export-D77619564 branch from 08e5478 to e2721c7 Compare

July 2, 2025 03:49

Contributor

facebook-github-bot commented Jul 2, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from 8ffdb89 to e0a27b8 Compare

July 2, 2025 19:45

facebook-github-bot pushed a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

7e02649

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

facebook-github-bot force-pushed the export-D77619564 branch from e0a27b8 to 7e02649 Compare

July 2, 2025 19:55

Contributor

facebook-github-bot commented Jul 2, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

facebook-github-bot pushed a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

65674ac

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

facebook-github-bot force-pushed the export-D77619564 branch from 7e02649 to 65674ac Compare

July 2, 2025 20:08

Contributor

facebook-github-bot commented Jul 2, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

f926223

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from 65674ac to f926223 Compare

July 2, 2025 22:31

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

6b06abc

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from f926223 to 6b06abc Compare

July 2, 2025 22:32

Contributor

facebook-github-bot commented Jul 2, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

9514ebb

… importlib_metadata (#1087)

Summary:
Pull Request resolved: #1087

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from 6b06abc to 9514ebb Compare

July 2, 2025 22:35

Contributor

facebook-github-bot commented Jul 2, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

ac7c948

… importlib_metadata (#1087)

Summary:
Pull Request resolved: #1087

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from 9514ebb to ac7c948 Compare

July 2, 2025 22:45


          (torchx/components) Remove dependency to pyre_extensions

40933b0

Differential Revision: D77621041

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

dcce28a

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from ac7c948 to dcce28a Compare

July 3, 2025 05:16

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

68386a8

… importlib_metadata (#1087)

Summary:

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from dcce28a to 68386a8 Compare

July 3, 2025 05:17

Contributor

facebook-github-bot commented Jul 3, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from 68386a8 to cf0c052 Compare

July 3, 2025 05:20

kiukchung added a commit that referenced this pull request


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

cf0c052

… importlib_metadata (#1087)

Summary:
Pull Request resolved: #1087

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564


          (torchx/entrypoints) Use importlib.metadata instead of the backported…

0d1b6de

… importlib_metadata (#1087)

Summary:
Pull Request resolved: #1087

torchx dropped support for python<=3.7 2 years ago (see: #728). But we kept using the backported `importlib_metadata` module to load configurations from `entry_points`.

Reviewed By: highker

Differential Revision: D77619564

kiukchung force-pushed the export-D77619564 branch from cf0c052 to 0d1b6de Compare

July 3, 2025 05:39

Contributor

facebook-github-bot commented Jul 3, 2025

This pull request was exported from Phabricator. Differential Revision: D77619564

facebook-github-bot merged commit 6641ab3 into main

23 of 24 checks passed

facebook-github-bot deleted the export-D77619564 branch

July 3, 2025 08:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported