Skip to content

Remove TorchScript part from the Saving and Loading tutorial #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Jun 26, 2025

Remove TorchScript part from the Saving and Loading tutorial

Copy link

pytorch-bot bot commented Jun 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3419

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 2 Pending

As of commit b8f37ff with merge base 3ea5abc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mikaylagawarecki
Copy link
Contributor

cc @angelayi on whether there's anything we should add re export serialization in this tutorial

@angelayi
Copy link
Contributor

@mikaylagawarecki thanks for the bump!
@svekars would it be possible to update this section to using export? It's very similar to TorchScript as you dont need to redefine the model class in order to run the model. Here are the docs for doing so: https://docs.pytorch.org/docs/main/export.html#serialization. Or I can do it in a separate PR!

@svekars
Copy link
Contributor Author

svekars commented Jun 26, 2025

@angelayi I added - can you take a look?

@malfet malfet merged commit a47d520 into main Jun 26, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants