Add custom class pt2 tutorial #3431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3431
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7a132ee with merge base 70c85a7 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
angelayi
force-pushed
the
angelayi/torchbind
branch
from
06880b9 to
be8b159
Compare
svekars
reviewed
Jul 8, 2025
advanced_source/custom_class_pt2.rst
Outdated
|
|
||
| import torch | ||
|
|
||
| torch.ops.load_library("//caffe2/test:test_torchbind_cpp_impl") |
There was a problem hiding this comment.
probably, I hope the OSS buck/bazel target for torch isn't caffe2 lol
There was a problem hiding this comment.
So it would be nice if we had some sample code someone could download that had the C++ extension set up with it. Then it would be clearer exactly what needs to be loaded (via load_library, or an import statement). But I'm happy to ship some version of this as-is without that because it already helps alot
ydwu4
reviewed
Jul 9, 2025
|
Thanks for porting this tutorial! Looks good to me. |
ydwu4
approved these changes
Jul 9, 2025
zou3519
reviewed
Jul 10, 2025
zou3519
reviewed
Jul 10, 2025
zou3519
reviewed
Jul 10, 2025
angelayi
force-pushed
the
angelayi/torchbind
branch
from
ba48f42 to
a198274
Compare
angelayi
force-pushed
the
angelayi/torchbind
branch
from
a198274 to
49ffb82
Compare
angelayi
force-pushed
the
angelayi/torchbind
branch
from
49ffb82 to
7a132ee
Compare
svekars
pushed a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting over part of https://docs.google.com/document/d/1xUfRsqyQp3CUqpHaPjG3APxx9gHEKjQ3ISYi5jtKpuk/edit?tab=t.0
preview: https://docs-preview.pytorch.org/pytorch/tutorials/3431/advanced/custom_class_pt2.html
cc @williamwen42 @msaroufim @anijain2305 @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @suo @ydwu4