Skip to content

fix mismatch between images and disparities in Kitti2015 #7452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix mismatch between images and disparities in Kitti2015 #7452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/test_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2746,23 +2746,23 @@ def inject_fake_data(self, tmpdir, config):
datasets_utils.create_image_folder(
root=split_dir,
name="image_2",
file_name_fn=lambda i: f"{i:06d}_10.png",
num_examples=num_examples,
file_name_fn=lambda i: f"{i // 2:06d}_1{i % 2}.png",
num_examples=num_examples * 2,
size=(3, 100, 200),
)
datasets_utils.create_image_folder(
root=split_dir,
name="image_3",
file_name_fn=lambda i: f"{i:06d}_10.png",
num_examples=num_examples,
file_name_fn=lambda i: f"{i // 2:06d}_1{i % 2}.png",
num_examples=num_examples * 2,
size=(3, 100, 200),
)

if config["split"] == "train":
datasets_utils.create_image_folder(
root=split_dir,
name="disp_occ_0",
file_name_fn=lambda i: f"{i:06d}.png",
file_name_fn=lambda i: f"{i:06d}_10.png",
num_examples=num_examples,
# Kitti2015 uses a single channel image for disparities
size=(1, 100, 200),
Expand All @@ -2771,7 +2771,7 @@ def inject_fake_data(self, tmpdir, config):
datasets_utils.create_image_folder(
root=split_dir,
name="disp_occ_1",
file_name_fn=lambda i: f"{i:06d}.png",
file_name_fn=lambda i: f"{i:06d}_10.png",
num_examples=num_examples,
# Kitti2015 uses a single channel image for disparities
size=(1, 100, 200),
Expand Down
8 changes: 4 additions & 4 deletions torchvision/datasets/_stereo_matching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,13 +334,13 @@ def __init__(self, root: str, split: str = "train", transforms: Optional[Callabl
verify_str_arg(split, "split", valid_values=("train", "test"))

root = Path(root) / "Kitti2015" / (split + "ing")
left_img_pattern = str(root / "image_2" / "*.png")
right_img_pattern = str(root / "image_3" / "*.png")
left_img_pattern = str(root / "image_2" / "*_10.png")
right_img_pattern = str(root / "image_3" / "*_10.png")
self._images = self._scan_pairs(left_img_pattern, right_img_pattern)

if split == "train":
left_disparity_pattern = str(root / "disp_occ_0" / "*.png")
right_disparity_pattern = str(root / "disp_occ_1" / "*.png")
left_disparity_pattern = str(root / "disp_occ_0" / "*_10.png")
right_disparity_pattern = str(root / "disp_occ_1" / "*_10.png")
self._disparities = self._scan_pairs(left_disparity_pattern, right_disparity_pattern)
else:
self._disparities = list((None, None) for _ in self._images)
Expand Down