Add WITH_LOCATION macros for propagating external library errors.
#9441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked until #9440 is merged. |
ysiraichi
force-pushed
the
ysiraichi/add-status-propagation-for-external-libs
branch
from
918f90a to
540d62e
Compare
- Refactor status tests - Remove test_status.cpp as its tests are now covered by specialized context tests - Both specialized tests now cover all status utility functions and macros
ysiraichi
force-pushed
the
ysiraichi/fix-status-location-logic
branch
from
0427c0a to
d6ba41f
Compare
- Add `XLA_RETURN_IF_ERROR_WITH_LOCATION` macro for external library status propagation - Add `XLA_ASSIGN_OR_RETURN_WITH_LOCATION` macro for external library status handling - Enhance test coverage with new test cases for location-specific macro variants - Improve macro documentation to clarify internal vs external usage patterns
ysiraichi
force-pushed
the
ysiraichi/add-status-propagation-for-external-libs
branch
from
540d62e to
487988e
Compare
ysiraichi
force-pushed
the
ysiraichi/fix-status-location-logic
branch
from
22a420a to
0242960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances PyTorch/XLA's error handling and status management, specifically for interactions with external libraries. In summary, this PR:
XLA_RETURN_IF_ERROR_WITH_LOCATIONandXLA_ASSIGN_OR_RETURN_WITH_LOCATION: new macros designed to propagate statuses from external library calls, including the exact source code location where the call to the library function that returned an error.These updates should improve our ability to track and debug issues originating from external library.