Add WITH_LOCATION macros for propagating external library errors.
#9441
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ysiraichi
force-pushed
the
ysiraichi/add-status-propagation-for-external-libs
branch
from
918f90a to
540d62e
Compare
ysiraichi
force-pushed
the
ysiraichi/fix-status-location-logic
branch
from
0427c0a to
d6ba41f
Compare
ysiraichi
force-pushed
the
ysiraichi/add-status-propagation-for-external-libs
branch
from
540d62e to
487988e
Compare
ysiraichi
force-pushed
the
ysiraichi/fix-status-location-logic
branch
2 times, most recently
from
0242960 to
620e4b6
Compare
ysiraichi
force-pushed
the
ysiraichi/add-status-propagation-for-external-libs
branch
from
487988e to
f072112
Compare
ysiraichi
changed the base branch from
ysiraichi/fix-status-location-logic
to
master
- Add `XLA_RETURN_IF_ERROR_WITH_LOCATION` macro for external library status propagation - Add `XLA_ASSIGN_OR_RETURN_WITH_LOCATION` macro for external library status handling - Enhance test coverage with new test cases for location-specific macro variants - Improve macro documentation to clarify internal vs external usage patterns
ysiraichi
force-pushed
the
ysiraichi/add-status-propagation-for-external-libs
branch
from
f072112 to
3f879bb
Compare
|
Hi Yukio, Let's discuss the design of this. I'm not sure that it's worthwhile asking the programmer to make the decision on whether they should collect the source location at each callsite. It's tedious. Also, the programmer may decide wrong and make it hard to see the source location at run time. I think we should just always collect the location, but don't show it by default. If the user requests to see the C++ context (BTW, I just found out about https://docs.pytorch.org/docs/stable/debugging_environment_variables.html - we should use the Does this make sense? Thanks. |
|
Got it. So, I will close this PR, and follow-up with what we discussed in our meeting. |
This PR enhances PyTorch/XLA's error handling and status management, specifically for interactions with external libraries. In summary, this PR:
XLA_RETURN_IF_ERROR_WITH_LOCATIONandXLA_ASSIGN_OR_RETURN_WITH_LOCATION: new macros designed to propagate statuses from external library calls, including the exact source code location where the call to the library function that returned an error.These updates should improve our ability to track and debug issues originating from external library.