-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests with multiple configuration files #49
Conversation
still needs a change in scrapyd-k8s to support the `-c` argument to load a specific configuration file, and allows multiple of them (`configparser` supports a list argument when loading for multiple files).
600060e
to
d527520
Compare
@vlerkin this is along the lines of what I thought. It keeps a better separation between the environment setup, and the actual test. And exactly the same test can be used for docker/k8s/in-cluster-k8s. There are some small but important issues to resolve. Are you able to look into this? I think it needs a bit of Linux knowledge, let me know if you need pointers (or ask around). |
3692ec1
to
8b1fb44
Compare
Ah, the k8s failure is actually very very simple: the service never comes up, because the health check is behind the auth. Bummer this issue is still open ... jpvanhal/flask-basicauth#11 |
8b1fb44
to
001890c
Compare
An attempt.
-c
argument for scrapyd-k8sTEST_
environment variables are passed through in CI config (do they needexport
?)kill %1
not working the very last time when running scrapyd-k8s directly (both docker and k8s; one thing to try would be to store the pid in a variable right after running it in the background, and killing the pid directly; or use another signal; may also be related to the note on termination in the next point) --> just needed towait
and ignore exit codeDocument how integration tests function, with config file adaptation, and how to run these tests easilythere is no doc about this, fix later