-
Notifications
You must be signed in to change notification settings - Fork 90
Add gitlab merge request note decoration #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please fix all build failures
|
||
@Data | ||
public class Gitlab { | ||
private Boolean enabled = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this flag needed? no configuration for Gitlab results in no Gitlab invocations
@@ -0,0 +1,45 @@ | |||
<#import "utils.ftl" as utils> | |||
<#compress> | |||
*${phrases.results}:* <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between html.ftl
and this template?
gitlabClient = new GitlabClient(gitlab); | ||
doReturn(prepareMessageValues()).when(messageData).getValues(); | ||
|
||
when(sendRequest.routeParam(anyString(), anyString())).thenReturn(sendRequest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any***
matchers do not provide enough confident quiality level
Поддерживается публикация отчета в комментариях к merge request. Для публикации необходимо указать следующие параметры конфигурации: | ||
<ul> | ||
<li><code>enabled</code> - признак выполнения публикации. Если ключ отсутствует или равен true, то публикация выполняется</li> | ||
<li><code>url</code> - адрес сервера gitlab</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an example
<li><code>enabled</code> - признак выполнения публикации. Если ключ отсутствует или равен true, то публикация выполняется</li> | ||
<li><code>url</code> - адрес сервера gitlab</li> | ||
<li><code>apiKey</code> - имя пользователя для аутентификации</li> | ||
<li><code>apiToken</code> - токен для аутентификации</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to get token?
<li><code>projectId</code> - идентификатор проекта в gitlab</li> | ||
<li><code>mergeRequestIid</code> - номер (iid) мерж реквеста в gitlab</li> | ||
</ul> | ||
Отчет публикуется в новом комментарии к мерж реквесту, на который указывает параметр <code>mergeRequestIid</code>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the same information to README.en.md
Added merge request note decoration by allure notification.

The example below demonstrates such kind of publication.