Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetStyle function can not get VertAlign format #2079

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

hly-717
Copy link
Contributor

@hly-717 hly-717 commented Jan 25, 2025

  • Fix redundant cols element generated by stream writer
  • Update dependencies module
  • Update docs for the GetCellRichText function
  • Move TestSetCellIntFunc function to cell_test.go

PR Details

Fix GetStyle function can not get VertAlign format

Description

Fix GetStyle function can not get VertAlign format

Related Issue

None

Motivation and Context

Fix GetStyle function can not get VertAlign format

How Has This Been Tested

I add the new test, old test had been passed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fix redundant cols element generated by stream writer
- Update dependencies module
- Update docs for the GetCellRichText function
- Move TestSetCellIntFunc function to cell_test.go
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (0e0e2da) to head (05b08da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2079   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          32       32           
  Lines       30057    30060    +3     
=======================================
+ Hits        29819    29822    +3     
  Misses        158      158           
  Partials       80       80           
Flag Coverage Δ
unittests 99.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit b19e594 into qax-os:master Jan 25, 2025
29 checks passed
xuri pushed a commit that referenced this pull request Mar 4, 2025
- Fix redundant cols element generated by stream writer
- Update dependencies module
- Update docs for the GetCellRichText function
- Move TestSetCellIntFunc function to cell_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Bugfix
Development

Successfully merging this pull request may close these issues.

2 participants