ci: run pytest matrix on PRs targeting dev (#241)#242
Closed
prakashUXtech wants to merge 1 commit into
Closed
Conversation
Extend ci.yml triggers so PRs against dev (not just main) get the 3.11/3.12/3.13 pytest matrix plus the lint job. The PR Quality Gate covers Conventional Commits + secrets + check-quality on every PR already; this adds the missing test-suite signal. Before: the entire v0.5.0 captain push merged to dev without per-PR pytest. Locally-passing tests were the only signal; regressions would have surfaced only on the eventual dev → main release PR. After: every dev PR gets the same matrix the main PRs do. Cost scales linearly with the dev-branch PR rate (~3/week during v0.5.x). Closes #241.
Issues (must fix)
Heads up
Please update your PR to address these points. |
|
This PR has been automatically marked as stale because it has not had activity in the last 14 days. It will be closed in 7 days if no further activity occurs. If you're still working on this, please push an update or leave a comment. |
|
Closing due to inactivity. If you'd like to continue, please open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Extends
.github/workflows/ci.ymltriggers so PRs targetingdevget the same pytest matrix (3.11/3.12/3.13) plus lint job that PRs targetingmainalready get. Three-line diff in theon:block.Why
The PR Quality Gate (
pr-quality-gate.yml) runs on every PR and covers Conventional Commit titles, secrets scan, and thecheck-qualitylint pass. But the pytest matrix fromci.ymlonly triggered on[main]. Result: the entire v0.5.0 captain push (11 PRs merged to dev between 2026-04-30 and 2026-05-02) shipped without per-PR pytest coverage. Local test runs were the only signal. Regressions in any single PR would only surface on the eventualdev→mainrelease PR.For a release with schema changes (#192 memory primitives, #108/#190 graph overhaul) and bug-fix surfaces (#234, in-flight #238), per-PR pytest is the difference between catching a regression on the PR vs. catching it after 9 PRs already merged.
Cost
CI cost scales linearly with the dev-branch PR rate. During v0.5.x that's ~3 PRs/week, which is well inside the GitHub Actions free tier.
Verification
This PR itself doesn't get pytest CI: it targets
devand the old workflow doesn't fire there yet, which is exactly the gap we're closing. After merge, the next PR targetingdevshould show the test matrix in its checks. The three mentee PRs (#236, #232, #237) will pick up CI on their next push.Closes #241.