Skip to content

Rework Coefficient Polynomials #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: set_submatrix
Choose a base branch
from

Conversation

Marvin-Beckmann
Copy link
Member

@Marvin-Beckmann Marvin-Beckmann commented Apr 20, 2025

Description

Similar to the previous PR, this PR reduces some code base for easier maintainability and adds unchecked methods.

  • unchecked getter and setter for polynomials
  • unchecked getter and setter for entries of matrices
  • a macro for compare base for easier implementations, such that it can be used for the polynomials + tests for availability
  • added a missing set_coefficient for PolynomialRingZq
  • use unchecked getter and setters in our code to improve the efficiency of our internal implementations.

For now I decided to only add the compare base types that were meaningful in my opinion, i.e. where we need it in our internal implementations.

Testing

  • I added basic working examples (possibly in doc-comment)
  • I triggered all possible errors in my test in every possible way
  • I included tests for all reasonable edge cases

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide
    • I have credited related sources if needed

@Marvin-Beckmann Marvin-Beckmann added enhancement📈 New feature performance⚡ This issue or PR should improve refactoring 🚜 Refactor code to improve consistancy labels Apr 20, 2025
@Marvin-Beckmann Marvin-Beckmann self-assigned this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement📈 New feature performance⚡ This issue or PR should improve refactoring 🚜 Refactor code to improve consistancy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant