Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to DRAG calibration #1055

Open
wants to merge 6 commits into
base: 0.2
Choose a base branch
from
Open

Enhancements to DRAG calibration #1055

wants to merge 6 commits into from

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Dec 6, 2024

Improvements for DRAG protocols.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (9723091) to head (2faf087).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              0.2    #1055      +/-   ##
==========================================
+ Coverage   96.96%   96.98%   +0.02%     
==========================================
  Files          98       99       +1     
  Lines        7932     8039     +107     
==========================================
+ Hits         7691     7797     +106     
- Misses        241      242       +1     
Flag Coverage Δ
unittests 96.98% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/protocols/__init__.py 100.00% <100.00%> (ø)
src/qibocal/protocols/drag.py 100.00% <100.00%> (ø)
src/qibocal/protocols/drag_simple.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@andrea-pasquale andrea-pasquale marked this pull request as ready for review January 15, 2025 09:29
@andrea-pasquale
Copy link
Contributor Author

andrea-pasquale commented Jan 15, 2025

@hay-k I'm asking a review from you since we had some discussions in the past about the drag calibration which was failing from time to time in your recalibration script. I think that using the nflips variable should reduce the chances of the fit failing since as you can see http://login.qrccluster.com:9000/0VD0ziRdS1SGw2NhY-Gv3g==/. Eventually you can give it a try also with the other protocol drag_simple.

@hay-k
Copy link
Contributor

hay-k commented Jan 16, 2025

I am also glad to see, that you have clarified the definition of beta, and the division by anharmonicity is not happening anymore. Back when I was looking into the DRAG code, I found it really confusing. It looked like part of the code was following a notation where beta is the entire coefficient in front of the quadrature component, and other parts of code were following a notation where the coefficient in front of the quadrature component is beta/anharmonicity.

Co-authored-by: Hayk Sargsyan <[email protected]>
@andrea-pasquale
Copy link
Contributor Author

I am also glad to see, that you have clarified the definition of beta, and the division by anharmonicity is not happening anymore. Back when I was looking into the DRAG code, I found it really confusing. It looked like part of the code was following a notation where beta is the entire coefficient in front of the quadrature component, and other parts of code were following a notation where the coefficient in front of the quadrature component is beta/anharmonicity.

Yes, we already made that change in #990. Some people follow the notation of beta/anharmonicity. In our case we don't really care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants