-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to DRAG calibration #1055
base: 0.2
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1055 +/- ##
==========================================
+ Coverage 96.96% 96.98% +0.02%
==========================================
Files 98 99 +1
Lines 7932 8039 +107
==========================================
+ Hits 7691 7797 +106
- Misses 241 242 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@hay-k I'm asking a review from you since we had some discussions in the past about the drag calibration which was failing from time to time in your recalibration script. I think that using the |
I am also glad to see, that you have clarified the definition of beta, and the division by anharmonicity is not happening anymore. Back when I was looking into the DRAG code, I found it really confusing. It looked like part of the code was following a notation where beta is the entire coefficient in front of the quadrature component, and other parts of code were following a notation where the coefficient in front of the quadrature component is beta/anharmonicity. |
Co-authored-by: Hayk Sargsyan <[email protected]>
Yes, we already made that change in #990. Some people follow the notation of beta/anharmonicity. In our case we don't really care. |
Improvements for DRAG protocols.
- [ ] add detuning