-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendored view cli #351
base: dev
Are you sure you want to change the base?
Vendored view cli #351
Conversation
q2cli/builtin/tools.py
Outdated
else: | ||
super().do_GET() | ||
|
||
VENDOR_PATH = '/home/anthony/src/qiime2/q2view/vendored/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we are going to need to do is add q2view to the build process for q2cli. We can handle that in the Makefile (this will be a bit similar to how we build the vendored visualizations in q2-diversity, so that is a pretty ok example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebolyen how do you feel about making q2view a submodule of q2cli to accomplish this?
Ok, I like the submodule approach I think. Acceptance Criteria:
|
Cli side of qiime2/q2view#25