Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendored view cli #351

Open
wants to merge 39 commits into
base: dev
Choose a base branch
from
Open

Vendored view cli #351

wants to merge 39 commits into from

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Dec 12, 2024

Cli side of qiime2/q2view#25

@Oddant1 Oddant1 added the stat:blocked This cannot be resolved until something else has changed. label Dec 12, 2024
@Oddant1 Oddant1 self-assigned this Dec 12, 2024
@Oddant1 Oddant1 changed the title Intial janky solution Vendored view Dec 12, 2024
@Oddant1 Oddant1 changed the title Vendored view Vendored view cli Dec 12, 2024
@Oddant1 Oddant1 requested a review from ebolyen January 22, 2025 18:48
@Oddant1 Oddant1 assigned ebolyen and unassigned Oddant1 Feb 4, 2025
else:
super().do_GET()

VENDOR_PATH = '/home/anthony/src/qiime2/q2view/vendored/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we are going to need to do is add q2view to the build process for q2cli. We can handle that in the Makefile (this will be a bit similar to how we build the vendored visualizations in q2-diversity, so that is a pretty ok example).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebolyen how do you feel about making q2view a submodule of q2cli to accomplish this?

@ebolyen
Copy link
Member

ebolyen commented Mar 27, 2025

Ok, I like the submodule approach I think.

Acceptance Criteria:

  • make dev will build the vendored q2view and write it to an in-package q2cli/assets/ (or q2cli/vendor/) directory which q2cli will then use once installed.
  • make install will do the same steps to vendor q2view as make dev. It should be verified that a conda build of the recipe includes the working vendored copy.
  • The source code of q2view should not be in the installed package itself, only the built JS application.

@ebolyen ebolyen assigned Oddant1 and unassigned ebolyen Mar 27, 2025
@ebolyen ebolyen moved this from In Review to In Development in 2025.4 🌻 Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:blocked This cannot be resolved until something else has changed.
Projects
Status: In Development
Development

Successfully merging this pull request may close these issues.

2 participants