Skip to content

Conversation

@zvecr
Copy link
Member

@zvecr zvecr commented Jan 4, 2026

Description

Currently the only way to infer problems is the absence of Git branch... in the qmk doctor output. As no error is actually reported, its not directly obvious that anything is wrong. Compilation then spits out the following errors when running qmk generate-version-h:

⚠ "git describe --abbrev=6 --dirty --always --tags" returned error code 128
⚠ "git describe --abbrev=6 --dirty --always --tags" returned error code 128
builddefs/build_keyboard.mk:291: *** multiple target patterns.  Stop.

Where users have previously then questioned "well doctor isnt reporting anything?".

The printing of the "safe.directory" git message to stdout causes the makefile to fall over and mask the actual error message.

Doctor now reports the following when the qmk_firmware repo has issue

Ψ Userspace enabled: False
⚠ Detected dubious ownership in repository!
Ψ CLI installed in virtualenv.
Ψ All dependencies are installed.

And the following when its just a single submodule:

Ψ Submodule status:
☒ - lib/chibios: <<< dubious ownership in repository >>>
Ψ - lib/chibios-contrib: 2025-10-03 18:22:15 +0200 --  (8d863d9e)
Ψ - lib/googletest: 2021-06-11 06:37:43 -0700 --  (e2239ee)
Ψ - lib/lufa: 2022-08-26 12:09:55 +1000 --  (549b973)
Ψ - lib/vusb: 2022-06-13 09:18:17 +1000 --  (819dbc1)
Ψ - lib/printf: 2022-06-29 23:59:58 +0300 --  (c2e3b4e)
Ψ - lib/pico-sdk: 2025-04-20 21:24:29 +1000 --  (d0c5cac)
Ψ - lib/lvgl: 2022-04-11 04:44:53 -0600 --  (e19410f)
Ψ QMK is ready to go

And compilation no longer falls over, producing:

make clean drop/cstm65:default
QMK Firmware 0.31.3
Deleting .build/ ... done.
Making drop/cstm65 with keymap default

⚠ "git describe --abbrev=6 --dirty --always --tags" returned error code 128
⚠ fatal: detected dubious ownership in repository at '/home/zvecr/zv_firmware_clean/lib/chibios'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/zvecr/zv_firmware_clean/lib/chibios

Generating: .build/obj_drop_cstm65_default/src/info_deps.d                                          [OK]
⚠ "git describe --abbrev=6 --dirty --always --tags" returned error code 128
⚠ fatal: detected dubious ownership in repository at '/home/zvecr/zv_firmware_clean/lib/chibios'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/zvecr/zv_firmware_clean/lib/chibios

arm-none-eabi-gcc (Arch Repository) 14.2.0
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Generating: .build/obj_drop_cstm65_default/src/info_config.h                                       Generating: .build/obj_drop_cstm65_default/src/default_keyboard.c                                  Generating: .build/obj_drop_cstm65_default/src/default_keyboard.h  

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Jan 4, 2026
@drashna drashna requested a review from a team January 9, 2026 23:31
@filterpaper filterpaper merged commit f8d6546 into qmk:develop Jan 10, 2026
5 checks passed
@zvecr zvecr deleted the doctor_safe_dir branch January 10, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants