Report permission issues in qmk doctor
#25931
Merged
+54
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the only way to infer problems is the absence of
Git branch...in theqmk doctoroutput. As no error is actually reported, its not directly obvious that anything is wrong. Compilation then spits out the following errors when runningqmk generate-version-h:Where users have previously then questioned "well doctor isnt reporting anything?".
The printing of the "safe.directory" git message to stdout causes the makefile to fall over and mask the actual error message.
Doctor now reports the following when the
qmk_firmwarerepo has issueAnd the following when its just a single submodule:
And compilation no longer falls over, producing:
Types of Changes
Issues Fixed or Closed by This PR
Checklist