-
-
Notifications
You must be signed in to change notification settings - Fork 43.3k
Simplify ctrl, shift, alt mods detection for Massdrop CTRL #8724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vomindoraan
approved these changes
Apr 7, 2020
Contributor
vomindoraan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ash0x0
approved these changes
Apr 7, 2020
zvecr
approved these changes
Apr 7, 2020
ridingqwerty
approved these changes
Apr 10, 2020
Contributor
ridingqwerty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
|
Thanks! |
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
Apr 12, 2020
Quarren42
pushed a commit
to Quarren42/qmk_firmware
that referenced
this pull request
Apr 15, 2020
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
thorstenweber83
pushed a commit
to thorstenweber83/qmk_firmware
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an "aesthetic" change, to use more modern code for detecting the states of the main modifiers.
Description
Makes use of the
MOD_MASK_macros instead of the expanded expressions when dealing with the modifier keys.Others should be able to see this and incorporate it in their own Massdrop layouts. The old model was:
vs
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Suggested by @ash0x0 at #8692.