Conversation
.github/workflows/test.yml
Outdated
| # fi | ||
| # done | ||
| ======= | ||
| unreleased-deps: |
There was a problem hiding this comment.
@nobuQuartile @AungKoKoLin1997 Can you explain the implications of enabling this job? I forget how it was disabled.
There was a problem hiding this comment.
@yostashiro I think it’s basically a guardrail to avoid merging PRs until their dependency PRs are merged and the dependent code is available as a proper release. But, I don't see this kind of cases often in our current practice.
So, I don't think it is worth to add CI for that for the repo.
There was a problem hiding this comment.
@AungKoKoLin1997 If enabling the job doesn't do any harm, we might as well enable it so we avoid the hassle of making local adjustments, no?
There was a problem hiding this comment.
@yostashiro Yes. We can avoid that.
So, lets bring back that CI.
@nobuQuartile Can you update your PR to enable that CI?
There was a problem hiding this comment.
@yostashiro @nobuQuartile My mistake. Just disable that CI because that CI will fail if there is any / in test-requirements.txt.
Since OCA repos are related each other, they don't have any kind of link inside this file but we have to put dependency modules from another repos in this file. So, this CI will always red.
There was a problem hiding this comment.
Okay, thanks for the explanation!
There was a problem hiding this comment.
I have commented it out.
3 participants
5617