Closed
Conversation
kakurai8
reviewed
Jan 3, 2023
kakurai8
left a comment
kakurai8
left a comment
There was a problem hiding this comment.
I checked the current status.
(Settings is added, but this module alone doesn't work.)
Contributor
Author
|
@kakurai8 This module alone will not work. This module is for base configuration and we need to use with other modules(sale_report_qweb_decimal_places, etcs). I am waiting Yoshi's approval and will continue working on another modules. |
yostashiro
requested changes
Jan 3, 2023
| </template> | ||
|
|
||
| Background: | ||
| ----------- |
Member
There was a problem hiding this comment.
Suggested change
| ----------- | |
| ~~~~~~~~~~~ | |
See OCA/maintainer-tools#455 (comment).
Please update the OCA PR as well.
yostashiro
requested changes
Jan 4, 2023
| </template> | ||
|
|
||
| Background: | ||
| ~~~~~~~~~~~ |
Member
There was a problem hiding this comment.
Suggested change
| ~~~~~~~~~~~ | |
| ~~~~~~~~~~~ | |
Please pay attention to the suggested blank line!
yostashiro
reviewed
Jan 4, 2023
report_qweb_decimal_place/README.rst
Outdated
Comment on lines
+59
to
+62
| To apply price unit format: | ||
| - Go to Invoicing --> Configuration --> Currencies | ||
| - Check apply_price_decimal_place field | ||
| - Define decimal place in price_decimal_place field |
Member
There was a problem hiding this comment.
Suggested change
| To apply price unit format: | |
| - Go to Invoicing --> Configuration --> Currencies | |
| - Check apply_price_decimal_place field | |
| - Define decimal place in price_decimal_place field | |
| To apply price unit format: | |
| #. Go to Invoicing --> Configuration --> Currencies | |
| #. Check apply_price_decimal_place field | |
| #. Define decimal place in price_decimal_place field |
yostashiro
approved these changes
Jan 4, 2023
Member
|
This module should be added in fal-oca. |
Member
|
Superseded by qrtl/fal-oca#9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3006