[3006][ADD] purchase_report_qweb_decimal_place#8
Merged
yostashiro merged 5 commits into16.0from Jan 28, 2023
Merged
Conversation
yostashiro
requested changes
Jan 5, 2023
Member
yostashiro
left a comment
There was a problem hiding this comment.
@AungKoKoLin1997 Can we put this module in https://github.com/OCA/purchase-reporting?
| @@ -0,0 +1 @@ | |||
| This module provides the price unit format of purchase report depends on the choice of price_decimal_places in currency. | |||
Member
There was a problem hiding this comment.
Suggested change
| This module provides the price unit format of purchase report depends on the choice of price_decimal_places in currency. | |
| This module provides the option to adjust the price unit format (number of decimal places to apply) | |
| of purchase report according to the configuration of price_decimal_places in currency. | |
| This module depends on report_qweb_decimal_place module in OCA/reporting-engine. |
yostashiro
requested changes
Jan 5, 2023
Comment on lines
+8
to
+16
| <xpath expr="//tbody//tr//td[5]" position="replace"> | ||
| <td class="text-end"> | ||
| <t t-set="currency" t-value="o.currency_id" /> | ||
| <t t-set="price_unit" t-value="line.price_unit" /> | ||
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | ||
| </td> | ||
| </xpath> |
Member
There was a problem hiding this comment.
Suggested change
| <xpath expr="//tbody//tr//td[5]" position="replace"> | |
| <td class="text-end"> | |
| <t t-set="currency" t-value="o.currency_id" /> | |
| <t t-set="price_unit" t-value="line.price_unit" /> | |
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | |
| </td> | |
| </xpath> | |
| <xpath expr="//span[@t-field='line.price_unit']" position="replace"> | |
| <t t-set="currency" t-value="o.currency_id" /> | |
| <t t-set="price_unit" t-value="line.price_unit" /> | |
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | |
| </xpath> |
To make the intention clearer and the design less breakable.
yostashiro
reviewed
Jan 5, 2023
Comment on lines
+8
to
+16
| <xpath expr="//span[@t-field='line.price_unit']" position="replace"> | ||
| <t t-set="currency" t-value="o.currency_id" /> | ||
| <t t-set="price_unit" t-value="line.price_unit" /> | ||
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | ||
| </xpath> |
yostashiro
requested changes
Jan 5, 2023
| @@ -0,0 +1,4 @@ | |||
| his module provides the option to adjust the price unit format (number of decimal places to apply) | |||
Member
There was a problem hiding this comment.
Suggested change
| his module provides the option to adjust the price unit format (number of decimal places to apply) | |
| This module provides the option to adjust the price unit format (number of decimal places to apply) |
yostashiro
approved these changes
Jan 5, 2023
1730284 to
7ab3078
Compare
Member
|
Same issue as #6 (comment). Ran pre-commit locally to confirm there is not issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3006