Calls order of q_invokable method #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mate Barany seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
The FolderListModel operates with QFileInfo and QUrl interfaces to provide file information in the provided path. The path used needs to be validated by the application developer for any illegitimate access. QUIP: 23 Task-number: QTBUG-136184 Pick-to: 6.10 6.9 6.8 Change-Id: I50a4737aa9193a5b9996a37cd865c49de7b84121 Reviewed-by: Oliver Eftevaag <[email protected]>
No critical security levels found. QUIP: 23 Fixes: QTBUG-136206 Pick-to: 6.10 6.9 6.8 Change-Id: I1a29dab77678a45cd5fe7391124791cbf6aa6ca8 Reviewed-by: Mitch Curtis <[email protected]>
The files (folders) already processed are listed in each issue in epic QTBUG-134547 These files were processed half a year ago. In order to make it clear that all of these files are already processed, mark them with an explicit default security header. For the record, this was generated with this script: find -E . -regex ".*\.(cpp|h|hpp|mm|qml|js)$" | xargs python3 ~/bin/add-cra-header.py in the folders listed in each subtask of QTBUG-134547 (add-cra-header.py only exist at my desktop, but it simply adds the default security header if it doesn't already have any existing security header) QUIP: 23 Fixes: QTBUG-134547 Pick-to: 6.10 6.9 6.8 Change-Id: Ieb8c78ea6561fdbdd27c7b13185ece853eedf80f Reviewed-by: Oliver Eftevaag <[email protected]>
This patch aims to improve readability and maintainability of the logic for deriving property type and flags before adding it to cache. Now resolution of the type happens in one place and derivation of flags in another one. This not only improves separation of concerns, but also makes the dependency between attributes and type more explicit and hopefully easier to follow. Task-number: QTBUG-98320 Change-Id: I64424e959ee11aa5c9a90c8e9fd2ca1347715342 Reviewed-by: Fabian Kosmale <[email protected]> Reviewed-by: Ulf Hermann <[email protected]> Reviewed-by: Sami Shalayel <[email protected]>
Expected type is more expressive and suitable for the current usecases than std::variant. Change-Id: Ib07885ce6f32036f4719432c0e4b5a1c7294f2b2 Reviewed-by: Fabian Kosmale <[email protected]>
This patch aims to extract the logic of transforming QV4::CompiledData::Property into QQmlPropertyData. Currently it's arguably a responsibility of QQmlPropertyCacheCreator because it is responsible for the resolution of property type, which is central to the creation of QQmlPropertyData. Such refactoring allows more detailed and robust testing of irProperty -> QQmlPropertyData, which is handy in the context of QTBUG-98320 to make sure that property attributes are propagated correctly to the QQmlPropertyData (and later to the cache). Change-Id: Iffdfd22f515016c61c087414f0c4530e43556091 Task-number: QTBUG-98320 Reviewed-by: Ulf Hermann <[email protected]>
Remove some code-duplication. Change-Id: Id04e81211fa9c65dde2ba41bbda02411933463d8 Reviewed-by: Olivier De Cannière <[email protected]>
We shouldn't include qtqml-config_p.h manually since it's not header-guarded. And especially we shouldn't include it twice. Also, sort and split the includes. In order to resolve QT_CONFIG, we include qtqmlglobal_p.h or qtqmlglobal.h. Change-Id: I933d8eff8581e91859a8a178bf92caeec2959215 Reviewed-by: Olivier De Cannière <[email protected]> Reviewed-by: Sami Shalayel <[email protected]>
The type of ValueFilter::value property been used with a variant type, but the documentation incorrectly mentions it as string type. This patch updates the correct type of this property. Fixes: QTBUG-140143 Pick-to: 6.10 Change-Id: I15141d256657f33e9e6c06cc3819f300bb9ab11c Reviewed-by: Mitch Curtis <[email protected]>
Change-Id: I82c6c648fce819e62adf13b39b80a65211795a4f Reviewed-by: Sami Shalayel <[email protected]>
If the binding throws an exception, the binding wrapper internally returns false. This should result in the value being discarded. We had a long standing bug in qtbase that caused the value to still be accepted in certain cases. Commit 440a63a33e7176167d91244467fa380bae684173 fixed that. Fixes: QTBUG-140161 Change-Id: Ib36a32909dc3d487bea887cb7f89d7fcfeca2031 Reviewed-by: Fabian Kosmale <[email protected]>
If the binding throws an exception, the binding wrapper internally returns false. This should result in the value being ignored, but wasn't for QObjectCompatProperty targets. That was fixed with 440a63a33e7176167d91244467fa380bae684173. However the test assumed that the binding would instead evaluate the error to an empty string. Adjust the condition to properly handle that. Change-Id: I6ff38c913866edbc9632bb854db00c29af036c82 Reviewed-by: Olivier De Cannière <[email protected]>
Change-Id: Ifa3c7a1aa81aec501b5a3ef5801d49242f78f55b Reviewed-by: Qt Submodule Update Bot <[email protected]>
Change-Id: I84881eca74ebd0876deafedc7498dc3cafdc6474 Reviewed-by: Anton Kudryavtsev <[email protected]> Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
The current documentation for the qmlformat tool uses two separate tables to list the available command line options and the available settings file variables. Some of the content is duplicated between the two tables, as the settings file variables always have an equivalent command line option to configure the same behavior. Despite the duplication, the two tables aren't entirely in sync and don't necessarily provide the same amount of information. For example, the command line options table misses some of the default value for certain configurable behaviors or, similarly, certain descriptions might be more thorough in one table rather than the other. Since both tables generally should present the same information for those features that can be configured both from a command line option and from a settings file variable, as they present two different but supposedly equivalent interfaces to the same feature, the tables are now unified into one, so as to ensure that the description and default value for the relevant elements can more easily remain in sync, further reducing the unnecessary duplication between the tables. In particular, the command line options table was expanded with an additional column, `Setting Name`, that is set to "N/A" when the command line option has no equivalent settings file variable and contains the relevant variable name, taken from the other table, when it does. The default values for the relevant element were moved from the settings file table to the now unified table where necessary. Since the command line options use flags for boolean variables, where a behavior is implicitly disabled unless the flag itself is present as part of the invocation, the meaning of "a default value of false" could be confusing, possibly suggesting that the user could pass a "false" or "true" value to the flag to set the behavior. To avoid this confusion, the "Default Value" column was modified to be a "Default State/Value" column, and the cell for rows that are affected by the above issues were modified to be defined as "disabled/false", hopefully making it more explicit that there is a difference between the state-based command line usage and the value-based settings file usage. The description for elements of the above kind was extended to be more specific about the difference in usage with regards to a command line invocation and a settings file customization. The descriptions for the relevant element were brought over from the settings file table where they either provided additional information or provided stronger layout for the presented information. The original settings file table was removed as its information is now embedded in the unified table. A "\target qmlformat-settings" command that pointed to the now removed settings file table was removed as it was unused in the project, with the consideration that the unified table already provides a "\target" that can be linked to if necessary. The title of the section presenting the table was modified to "Options and settings" to explicit the presence of the new unified information. A phrase referring to the command line options table as presenting the available command line options was modified to explicit the presence, in the now unified table, of both command line options and settings file variables. Fixes: QTBUG-139125 Change-Id: Iedcc9ee0a1b3a70417db10736cef4a2955b43750 Reviewed-by: Paul Wicking <[email protected]> Reviewed-by: Sami Shalayel <[email protected]>
No security critical issues identified for the qt labs platform. QUIP: 23 Task-number: QTBUG-136184 Pick-to: 6.10 6.9 6.8 Change-Id: If2d0e6991463ed9994fba8adbc3eef848984ab45 Reviewed-by: MohammadHossein Qanbari <[email protected]>
The parser for QML allows the specification of type hints on a series of
callable elements; such as functions defined as part of a QML type.
It is possible, for example, to provide an hint for the return type of a
function expression, anonymous or not, such as:
```
import QtQml
QtObject {
property var: function (lhs: int, rhs: int)): int { return lhs + rhs; }
}
```
While this parses correctly, the return type annotation is currently
discarded as part of the parsing process, such that in turn it is
invisible to the engine when managing the function.
Hence, ensure that the return type annotation for function expressions
is preserved during the parsing process so that it can later be visible
to the engine.
In particular, the AST node that represents this kind of element can
already store a type annotation that refers to its return type and later
down the line, the code generation phase is already able to take into
account the annotation when it builds its representation of the function.
Nonetheless, that storage is currently purposefully not used in the
cases we are interested into, albeit it is in other cases that might be
considered more common.
This is most probably, albeit nowhere near certainly, due to simple
historical reasons and partial implementations related to type hints.
Thus, ensure that the return type annotation is correctly preserved and
stored for `FunctionExpression` rules during the parsing process, such
that it can later be recognized and used by the engine.
A few test cases related to the return type annotation were added.
Pick-to: 6.10
Task-number: QTBUG-137944
Change-Id: I6133bb286a916d0687ff5d5542b9aa769cfd493b
Reviewed-by: Ulf Hermann <[email protected]>
Reviewed-by: Sami Shalayel <[email protected]>
Component.onCompleted: {
if(true) /* true */ {
// the true clause
} else {
// the else clause
}
}
was formatted to :
Component.onCompleted: {
if (true /* true */)
// the true clause
{} else
// the else clause
{}
}
Add a new parameter to outWithComments that allows to change the
indentation. The use cases are:
```
{
// 1) some comment attached to '{'
...
// 2) some comment attached to '}'
}
```
For 1), IncreaseIndentation prints '{' and then increase the
indentation before printing any post comment.
For 2), DecreaseIndentation prints the pre comments, decrease the
indentation and then proceed with '}' and potential post comments.
This allows to print the comments attached to `{}` tokens with the
correct indentation.
Also adapt a test to the new comment behavior on blocks.
Pick-to: 6.10
Task-number: QTCREATORBUG-33333
Task-number: QTBUG-123386
Change-Id: If8dd483a520c3bd25e161f3cec05530c1460bb80
Initial-patch-by: Xavier BESSON <[email protected]>
Reviewed-by: Olivier De Cannière <[email protected]>
Avoid using split().size() and a QString and directly use count(). Avoid unnecessary copies of bPath on the stack by using a reference, and only stringappend "_deps" to the current build folder once. Also use QDirListing instead of creating a QDir to avoid creating an extra temporary list. Change-Id: Ie3bb05d8c70a0aa8380001ea76f77faa114aba18 Reviewed-by: Fabian Kosmale <[email protected]>
Fixes build error from testing for an unknown feature flag, i.e. tst_qmltyperegistrar.cpp:1439:6: error: division by zero in preprocessor expression As it's a private feature, include a private header. Pick-to: 6.10 Change-Id: I6112d73ebb738a555c05211d8f6c29a053de7b39 Reviewed-by: Fabian Kosmale <[email protected]> Reviewed-by: Mårten Nordheim <[email protected]>
Fix linking issues in qqmlsortfilterproxymodel.cpp:
qqmlsortfilterproxymodel.cpp:86: (qdoc) warning: Can't link to
'SortFilterProxyModel::setPrimarySorter(sorter)'
qqmlsortfilterproxymodel.cpp:343: (qdoc) warning: Can't link to
'recursiveFilteringEnabled'
Add an \internal class topic for private class QQmlSortFilterProxyModel.
This removes warnings such as:
qqmlsortfilterproxymodel.cpp:287: (qdoc) warning: No output generated
for 'QQmlSortFilterProxyModel::~QQmlSortFilterProxyModel()'
because 'QQmlSortFilterProxyModel' is undocumented
Pick-to: 6.10
Change-Id: I6ea3a6be606a5fdff18750beab28cdb16dba9755
Reviewed-by: Mate Barany <[email protected]>
The TestResult type has never been documented, but the source code
contains QDoc documentation comments for a number of its properties.
Add a \qmltype topic for the type and mark it \internal, to remove
QDoc warnings such as
quicktestresult.cpp:184: (qdoc) warning: No output generated for QML
property 'TestResult::testCaseName' because 'TestResult' is
undocumented
Change-Id: I4021c482f145e591c2c8434ff016d547fc465ad9
Reviewed-by: Andreas Eliasson <[email protected]>
Reviewed-by: Mitch Curtis <[email protected]>
Mark all files as significant. Use reason:trusted-sources on files that spawn QProcess or parse data: * qdochtmlparser.cpp parses content obtained from the QHelpEngine, which is a trusted source * qqmlcodemodel is used to spawn QProcesses that runs CMake (which is a trusted source) with arguments from QQmlLSUtils::cmakeBuildCommand(const QString &path) (which is also a trusted source) or trusted hard-coded arguments. Pick-to: 6.10 6.9 6.8 Fixes: QTBUG-136201 Change-Id: I3f2ff1dfc208224baff6fe88b337fe24c44b599a Reviewed-by: Ulf Hermann <[email protected]>
Mark all files as significant. Pick-to: 6.10 6.9 6.8 Task-number: QTBUG-136187 Change-Id: I655241e8fd460f423c230b3ae2979246f4ffc841 Reviewed-by: Ulf Hermann <[email protected]>
Don't search C++ headers on fallback code model: the url is empty so it seems we end up searching the current working directory(?) of qmlls for C++ headers. This might have caused some flakyness in tst_qmlls_qqmlcodemodel where some unrelated tests timeout because of this useless search. Change-Id: I0a5c9071cdd5a2f06f5ef8b392b2091b357e4887 Reviewed-by: Ulf Hermann <[email protected]>
It seems that FlexboxLayout.Row is actually ambiguous: it could refer to the "Row" enum value, and to the attached type of "Row" which is attached on the attached type of "FlexboxLayout". Fix qmllint to follow the qml engine's interpretation of the thing, and resolve it as an enum instead of a chained attached type in QQmlJSTypeResolver. Pick-to: 6.10 6.8 Fixes: QTBUG-141194 Change-Id: I24e23f5fc92b0d007ff1d628b6286f85a60f10d8 Reviewed-by: Fabian Kosmale <[email protected]>
.. and use the values from the fallback codemodel directly instead. Also make changes in the build or import paths be directly reflected in the DomEnvironments. Change-Id: Ie3c6460c88699d80008c7680281fa9d17f3a7d74 Reviewed-by: Fabian Kosmale <[email protected]>
Run CMake when opening a workspace, right after CMake was enabled. Add a scenario in the manual test for this feature, and disable CMake builds in some tests to avoid running CMake in unrelated tests and making them slower. Fixes: QTBUG-119163 Change-Id: Ia076db3d44fa41db747dc09afdb2902be0c472a3 Reviewed-by: Ulf Hermann <[email protected]> Reviewed-by: Fabian Kosmale <[email protected]>
With \c, the brief gets rendered as: Customizes the value of no<@op>-</@op>cmake<@op>-</@op>calls in .qmlls.ini files for QML Language Server. Pick-to: 6.10 Change-Id: Ib4579d70d10097872cc1bd93092fbf7d2a6c1bc1 Reviewed-by: Leena Miettinen <[email protected]>
Amends ce69cc7 Pick-to: 6.10 Change-Id: I43b514bc390f84151814eb74b3062c80162218c3 Reviewed-by: Fabian Kosmale <[email protected]>
QCOMPARE(QPointF, QPoint) requires too much precision: it can fail by a fractional pixel. Amends ff4c2c3 Pick-to: 6.10 6.8 Change-Id: Icdcc895e855ea305090d1d4863b7c0f078922427 Reviewed-by: Shawn Rutledge <[email protected]>
Clarify that the touch-hover behavior doesn't depend on touch->mouse synthesis. We started faking hover on touchscreens because MouseArea can handle synth-mouse events coming from touchscreens, so containsMouse was reacting to touchpoints: then QTBUG-40856 came along, and the fix for it cemented some rules in place. Then HoverHandler was added, and it was deemed reasonable to get similar behavior, even though it handles touch events directly: if your fingertip is touching, then the rest of your finger is hovering (just as the mouse cursor is hovering at the same time that the mouse button is pressed). In this test case, HoverHandler directly handles touch events, and there is no touchmouse. So far, we still have Qt 5 behavior: HoverHandler is a single-point handler, and if you try to press two of them with two fingers, the first one "wins". But this might need to change later, to support multi-finger hover. Task-number: QTBUG-40856 Change-Id: If46d766d80534d729d254ca12ed1069c1d94e7a4 Reviewed-by: Richard Moe Gustavsen <[email protected]>
…ition() QQuickPopupPrivate::handleMouseEvent() has already converted from `item->mapToScene(point.position())` to `point.scenePosition()`: 1. fe86b0f 2. e481f1c Give QQuickPopupPrivate::handleTouchEvent() the same treatment to fix swiping open Drawers by touch. Change-Id: Ieb4b8f0677043f09771e5700c8d441cc90d7fa75 Fixes: QTBUG-132914 Pick-to: 6.10 6.8 Reviewed-by: Shawn Rutledge <[email protected]>
Unfriend LoggerCategory and actually implement accessor functions. Amends cdd7fe0 Change-Id: Iee580f98d84ec554467cb8ab779a4178c7f745fc Reviewed-by: Sami Shalayel <[email protected]>
When we get the bounds for our masked item, we need the bounds of the actual shape it contains. This means we want to apply all styles except the transform, since the transform will be applied to the ShaderEffect item later on. All the other styles might affect the content bounds. We could perhaps solve this by adding a contentBounds() to QSvgNode, which returns the bounds untransformed, but for now we just apply the inverted transform to the rect afterwards to cancel the effect. This of course means that if you set a degenerate transform on the item, it will not work correctly, but that implies that you are scaling one of the axes by 0, so this is theoretical corner case. Fixes: QTBUG-141168 Change-Id: I3221e599cf4bfe48733173ecb13e28058066b19c Reviewed-by: Hatem ElKharashy <[email protected]>
If the initial window width was so large that the inital layout was
determined to be the "largeLayout" (wider than 450 pixels), then the
binding
columns: Math.min(Math.round(width / 130), 6)
initially resulted in 0 columns because the width was initially
evaluated to be 0, which caused the grids implicitWidth to be 0 (because
it couldn't fit any items when columns was 0). Hence, it was
"deadlocked": it didn't add items because columns was 0, and it
didn't increase columns because it's width was 0.
An item in a layout with implicitWidth == 0 will always have lower
priority to grow than items with a larger implicitWidth - hence the grid
was stuck at width == 0
Pick-to: 6.10 6.8
Fixes: QTBUG-140533
Change-Id: I558463ac33db36fa7eb8df4c70adc94f90c69e8f
Reviewed-by: Santhosh Kumar <[email protected]>
Reviewed-by: Tor Arne Vestbø <[email protected]>
Don't rely on auto-linked text for QtQuick. Instead, link explicitly to specific pages. Use markup to display a token from a quoted file, and to prevent auto-linking. Change-Id: I4de0f12e4c757dc47abcffaf05ead9f0ab6fabeb Reviewed-by: Sami Shalayel <[email protected]>
QDoc is able to refer to whole property groups using \since commands, so we can replace hard-coded text with those. Change-Id: I712e24cac48190ba805795e0d8e4abc18732b785 Reviewed-by: Mitch Curtis <[email protected]>
The two computations may result in the same string. Insert the second one only if it is differnt. Amends c4455f1 Pick-to: 6.10 Change-Id: I0c4df0cf6bb5bba2c1cf6c50b8a7f105718b85ee Reviewed-by: Sami Shalayel <[email protected]>
This is apparently better than using globalObject. registerModule was introduced in 3464655. Pick-to: 6.8 6.10 Change-Id: Ic664e65d7e5f8d65004112802e8f19f4f790bb7d Reviewed-by: Ulf Hermann <[email protected]>
So when we touch-press the right HoverHandler, the left stays hovered sometimes. Hmm. Let's check the right one first, and see if that's also flaky. Subsequent hover patches may affect behavior here: that's what we are checking for. Task-number: QTBUG-141430 Change-Id: I10709cc454f25be91159c520a385603de7067acf Reviewed-by: Shawn Rutledge <[email protected]>
Fixes: QTBUG-141198 Pick-to: 6.10 Change-Id: I1235d021416d43c00cc856f10e826369a34c826c Reviewed-by: Safiyyah Moosa <[email protected]>
Add API for specifying individual corner radius values similar to Quick Rectangle. Try to keep the overhead minimum when not used, by storing data in lazily allocated extra and using separate shader. Use the API in the neumorphicpanel example. Task-number: QTBUG-141110 Change-Id: I90e558526dff01c88fb2d163a33704b8f73aa1fc Reviewed-by: Richard Moe Gustavsen <[email protected]>
… ready" This reverts commit 2127cbb. Reason for revert: The timeout bug has a fix now. Task-number: QTBUG-139591 Change-Id: I90d8c797c7e327bfb92baea3000157048ca3d685 Reviewed-by: Ulf Hermann <[email protected]> Reviewed-by: Mitch Curtis <[email protected]>
Change-Id: I17312a39bc4fbd6a6de3f177cb8667666799bf76 Reviewed-by: Qt Submodule Update Bot <[email protected]>
Some fields under QtView and thus under QtQuickView are marked as protected which ends up shown in javadoc. These fiedls are internal and shouldn't be treated as public, so instead, make them private and provide package-private getters/setters for QtQuickView to access those fields internally. Task-number: QTBUG-141365 Change-Id: Ibefd262412a07b323ff9c40bcf57f5da21b53975 Reviewed-by: Jani Heikkinen <[email protected]>
tst_QQuickContextMenu::menuItemShouldntTriggerOnRelease() has always been flaky (introduced in dac8529). Skip it to unblock submodule update. Task-number: QTBUG-133302 Task-number: QTBUG-137400 Task-number: QTBUG-141398 Task-number: QTBUG-141406 Pick-to: 6.10 6.9 Change-Id: I3bc1e02d7e5ac81296d85b6b40a602f820a25118 Reviewed-by: Shawn Rutledge <[email protected]>
The intention was always to run it with every single built-in style. Previously the Imagine style was omitted because of an issue that needed more investigation. It seems like that has since been resolved, and that it's safe to include it in the list of styles to run tst_qquickfiledialogimpl with. Change-Id: I7634a938c550392f8f5c18c141404c80a7ab99b2 Reviewed-by: Mitch Curtis <[email protected]>
This makes it more convenient to test changes to dialogs for both popup types. Only Popup.Item and Popup.Window are relevant for dialogs at the moment. Change-Id: I766030dee06d342c115941e83acb74afedc82921 Reviewed-by: Mitch Curtis <[email protected]>
Amends 6eaa956 Pick-to: 6.5 6.8 6.10 Change-Id: I195e26fa1a703607b1d65d57e5dc43a072b05e72 Reviewed-by: Mitch Curtis <[email protected]>
Change-Id: Ifd85cfa7567aee1e13369b1d16ac0da7bd69a860 Reviewed-by: Oliver Eftevaag <[email protected]>
As it stood, the progress bar groove would not be resized according to the size of the control, since it lacked at width binding. This patch will make sure to resize the groove correctly. It also fixes a binding loop warning related to the use of Loaders in combination with childrenRect in the same go. Fixes: QTBUG-141182 Pick-to: 6.10 6.9 6.8 6.5 Change-Id: I1aa87db339b04686ca521b486e4c7a05683a7679 Reviewed-by: Tor Arne Vestbø <[email protected]>
With Liquid Glass enabled, the groove of the Slider and RangeSlider had a border which made the groove look taller than the track/progress (which had no border). But looking more carefully at the native NSSlider in Xcode, it shows that the Slider groove (and track) should no longer have any border at all (which is different from how it looks in macOS 15). This patch will therefore draw the track without a border when running with Liquid Glass. Using nested rectangles in order to draw the slider in the macOS 15 style was also unnecessary, as we can achive the same look by using a single Rectangle. Pick-to: 6.10 6.9 6.8 6.5 Change-Id: I9d03a212f39857a448d103372636e9a12a7cbd3f Reviewed-by: Tor Arne Vestbø <[email protected]>
Support relative import paths in qmlls.build.ini and .qmlls.ini files. Add a helper function in QQmlToolingSettings that takes care of resolving paths, and use it in qmlls. A later commit will also use it when loading .qmllint.ini files. Fixes: QTBUG-141219 Pick-to: 6.10 Change-Id: Idc22ac07f7aa9910f7e5a6ca51115a457a909fa6 Reviewed-by: Fabian Kosmale <[email protected]>
Use the same logic as qmlls to load import paths in qmllint: QVariant::toStringList() always returns a QStringList() of length one. Instead, use the QDir::listSeparator() char to split the list into multiple one, allowing the users to pass multiple paths via settings files. Somehow the setting file entries to pass paths to qmllint are not documented, so no need to update the documentation it seems. Pick-to: 6.10 Task-number: QTBUG-141385 Change-Id: Iaf34c09601bfb423ceb658e9a87a961b5d8c1c90 Reviewed-by: Fabian Kosmale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
38 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are 2 or more methods with the same name but reciving diferent arguments the QJSEngine Pickup the First One declared.
Example:
methodxyz(string)
methodxyz(objptr*)
It picks up the first one passing as argument a string and not the one that i was expecting an object as it was send.