Skip to content

QDAC2 wiring#341

Open
TheoLaudatQM wants to merge 5 commits into
mainfrom
feature/qdac_wiring
Open

QDAC2 wiring#341
TheoLaudatQM wants to merge 5 commits into
mainfrom
feature/qdac_wiring

Conversation

@TheoLaudatQM

@TheoLaudatQM TheoLaudatQM commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Summary

feature/qdac_wiring adds QDAC-II (QDAC2) to qualang_tools.wirer: instrument channels, add_qdac2, qdac2_spec, DC allocation (alone or with LF-FEM / OPX+), and visualizer support.

Commits: First add QDAC2 to the InstrumentsAdd qdac to the wirer with specs and visualizer
Scope: ~13 files, +349 / −4 lines vs main.

What changed

Model & registry

  • New instrument_id: "qdac2".
  • Types: InstrumentChannelQdac2Output, InstrumentChannelQdac2DigitalInput (24 DC outs, 4 trigger ins per unit).
  • Constants: NUM_QDAC2_OUTPUT_PORTS, NUM_QDAC2_DIGITAL_INPUT_PORTS.
  • Instruments.add_qdac2(indices) registers all ports for each unit on available_channels.

Specs & API

  • ChannelSpecQdac2 / qdac2_spec(index=..., out_port=..., trigger_in_port=...) — DC line + optional external trigger input when the line is triggered.
  • Exported from qualang_tools.wirer.

Allocation

  • allocate_dc_channels tries QDAC2-only masks, and extra masks when constraints combine LF-FEM ∧ QDAC2 or OPX+ ∧ QDAC2 (dual channel per gate, with digitals when triggered).

Visualizer

  • QDAC2 figure: 3×8 DC grid + 4 trigger inputs; layout tuned so labels sit inside the panel.

Tests

  • New test_wirer_qdac2_voltage_gates.py; updates to instrument validation and visualizer tests.

Compatibility

Additive / non-breaking for existing wirer usage.

Note

quam-builder (and similar) can map allocated QDAC2 channels into QUAM qdac_output / qdac_trigger wiring; that lives outside this repo.

Related to PR-103 on quam-builder.

Remember to:

  • Update the CHANGELOG.md
  • Added tests for the feature or fix

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 7bab439.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant