Skip to content

Return null if can't compare snapshots #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxim-v4s wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Return null if can't compare snapshots #261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b8238d
feat: return null if can't compare snapshots
maxim-v4s Sep 15, 2025
a3e42fe
Merge branch 'main' into feat/null_if_snapshot_res_not_comparable
maxim-v4s Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions backend/qualibrate_app/api/routes/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
from qualibrate_app.api.core.utils.request_utils import get_runner_config
from qualibrate_app.api.core.utils.types_parsing import types_conversion
from qualibrate_app.api.dependencies.search import get_search_path
from qualibrate_app.api.exceptions.classes.base import QualibrateException
from qualibrate_app.api.routes.utils.dependencies import (
get_snapshot_load_type_flag,
)
Expand Down Expand Up @@ -91,8 +92,11 @@ def get_history(
def compare_by_id(
id_to_compare: IdType,
snapshot: Annotated[SnapshotBase, Depends(_get_snapshot_instance)],
) -> Mapping[str, Mapping[str, Any]]:
return snapshot.compare_by_id(id_to_compare)
) -> Mapping[str, Mapping[str, Any]] | None:
try:
return snapshot.compare_by_id(id_to_compare)
except QualibrateException:
return None


@snapshot_router.post("/update_entry")
Expand Down