remove unused pulse registry scaffolding#104
Open
sebastianorbell-qm wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR removes the pulse-registry scaffolding that is not currently used by the runtime pulse wiring flow.
Today, default pulses are materialized directly in
macro_engine.wiring._ensure_default_pulses()from concrete channel instances. The extrapulse_registry.py/register_default_component_pulse_factories()layer was not the active path and added confusion around where pulse-default changes should actually be made.What Changed
quam_builder/architecture/quantum_dots/operations/pulse_registry.pyregister_default_component_pulse_factories()and related reset plumbingoperations/__init__.pyexports to match the simplified pulse surfacecomponent_pulse_catalog.pyas helper pulse builders only_ensure_default_pulses()as the single default-pulse materialization pathWhy
The pulse code had two competing shapes:
_ensure_default_pulses()In practice, the registry layer was placeholder-only, while the wiring layer did the real work. Removing the unused layer makes the code clearer and makes future pulse changes easier to place correctly.
Impact
Validation
Ran:
All 18 tests passed.
Notes
This branch was preserved from an exploratory cleanup so the change can be discussed separately from the ongoing QDAC/baseband pulse work.