Skip to content

refactor: applying black formatting/pylint to entire repo#128

Merged
JacobFastQM merged 5 commits into
mainfrom
refactor/formatting
Jun 29, 2026
Merged

refactor: applying black formatting/pylint to entire repo#128
JacobFastQM merged 5 commits into
mainfrom
refactor/formatting

Conversation

@JacobFastQM

@JacobFastQM JacobFastQM commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

This PR applies black formatting and fixes pylint warnings across the repo to bring it in line with our formatting standards. No functional changes are included.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ✅ Test addition/update
  • 🎨 Code style/formatting update

Checklist

Code Quality

  • My code follows the project's style guidelines
  • I have run pre-commit hooks and all checks pass (pre-commit run --all-files)
  • My commits follow the Conventional Commits format
  • I have performed a self-review of my code
  • My changes generate no new warnings

Testing

  • no new tests required

Documentation

  • I have updated the CHANGELOG.md (if applicable)
  • I have checked my code and corrected any misspellings

@JacobFastQM JacobFastQM changed the title refactor: applying black formatting to entire repo refactor: applying black formatting/pylint to entire repo Jun 17, 2026
Comment thread pylint_qua_plugin/pylint_qua_plugin.py

@OziEgri OziEgri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes look good, but there are some, which I commented on, that need further checking. Generally speaking, this is a huge PR, and I think a PR of this size should be justified with major contribution/improvements to the code, and I am afraid with pylint is not the case. I would strongly recommend reverting all those changes. What do you think @JacobFastQM

Comment thread quam_builder/architecture/quantum_dots/components/quantum_dot.py Outdated
Comment thread quam_builder/architecture/quantum_dots/qpu/base_quam_qd.py
Comment thread quam_builder/architecture/quantum_dots/qpu/base_quam_qd.py
Comment thread quam_builder/builder/qop_connectivity/create_analog_ports.py
Comment thread quam_builder/tools/power_tools.py
@JacobFastQM JacobFastQM force-pushed the refactor/formatting branch from ae63886 to 009ecb0 Compare June 29, 2026 17:31

@OziEgri OziEgri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all comments were answered

@JacobFastQM JacobFastQM merged commit 8b71c22 into main Jun 29, 2026
5 checks passed
@JacobFastQM JacobFastQM deleted the refactor/formatting branch June 29, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants