docs: fix hardcoded resonator output ports in demonstration.md#222
Open
aranbqm wants to merge 1 commit into
Open
docs: fix hardcoded resonator output ports in demonstration.md#222aranbqm wants to merge 1 commit into
aranbqm wants to merge 1 commit into
Conversation
The resonator initialization in the Populating the Machine loop hardcoded
opx_output_I/Q to ("con1", 1)/("con1", 2) for every qubit, even though the
loop iterates idx to give each qubit distinct ports. The printed
machine.print_summary() output later in the same doc shows q0 with
('con1', 1)/('con1', 2) and q1 with ('con1', 4)/('con1', 5), i.e.
3 * idx + 1 / 3 * idx + 2 — the code didn't match its own shown output.
opx_input_I/Q are left as-is since they are intentionally shared across
qubits.
|
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
docs/demonstration.md, the "Populating the Machine" example initializes each qubit's resonator inside afor idx in range(num_qubits)loop, but hardcoded the same output ports for every qubit:This contradicts the
machine.print_summary()output shown further down in the same doc, which reports distinct ports per qubit:q0has('con1', 1)/('con1', 2)andq1has('con1', 4)/('con1', 5)— i.e.3 * idx + 1/3 * idx + 2, matching the pattern already used for thexyandzchannels a few lines above.Fix
opx_output_I=("con1", 1)→opx_output_I=("con1", 3 * idx + 1)opx_output_Q=("con1", 2)→opx_output_Q=("con1", 3 * idx + 2)opx_input_I/opx_input_Qare left unchanged as("con1", 1)/("con1", 2), since those are intentionally shared across qubits.Test plan
machine.print_summary()output later in the same doc to confirm the formula produces the shown ports for q0 and q1.