Performance: Tiotest runner improvements + lib_performance numeric helpers #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move common numeric/normalization helpers into lib_performance.sh. - Add norm_metric(), is_number(), append_if_number() - Keep helpers POSIX/ShellCheck clean and reusable across runners - No behavior change in existing callers until follow-up commits Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
…unknown fields Update Tiotest runner to rely on shared lib_performance helpers. - Switch to norm_metric()/is_number()/append_if_number() from lib_performance.sh - Avoid printing misleading 'unknown' when latency fields are intentionally hidden - Keep baseline gating, iteration flow, and output format unchanged otherwise Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Update Tiotest baseline configuration to match runner metric naming.
- Ensure {seqwr,seqrd,rndwr,rndrd}_{mbps,iops} keys align with emitted metrics
- Preserve existing threshold intent; no change in performance expectations
Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Wire Tiotest into the CI/LAVA performance workflow. - Add Tiotest invocation with explicit args and output directory - Ensure result files are uniquely named/saved for CI artifacts - Keep execution order consistent with existing performance runners Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Document Tiotest usage for local runs and CI/LAVA. - Add example command lines and common options (threads/modes/iterations) - Describe baseline gating behavior and how to update baseline safely - Note output artifacts (logs, metrics TSV, summary, .res) Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Tiotest performance runner and aligns it with our review expectations (commit order + shared helpers reuse).
What’s included
Sysbench bug #253 will also get address with commit