Add test script to validate USB HID #259
Conversation
achauras-qcom
force-pushed
the
feature/usb-hid
branch
from
b6c8c6e to
9ae698c
Compare
The shell script verifies the enumeration of USB Human Interface Devices. Signed-off-by: “Aanchal <[email protected]>
Added setup information and basic requirements. This informs the tester of the hardware setup requirement before starting test. Signed-off-by: “Aanchal <[email protected]>
Individual test definition is meant to be used for debugging the test script running in LAVA. Signed-off-by: “Aanchal <[email protected]>
achauras-qcom
force-pushed
the
feature/usb-hid
branch
from
9ae698c to
030a8d7
Compare
| # Requires at least one USB HID peripheral (keyboard/mouse, etc.) connected to a USB Host port. | ||
|
|
||
| # Robustly find and source init_env | ||
| SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" |
There was a problem hiding this comment.
Can this we replace a below to maintain parity with other scripts
SCRIPT_DIR="$( cd "$(dirname "$0")" || exit 1 pwd )"
| fi | ||
|
|
||
| # Only source if not already loaded (idempotent) | ||
| if [ -z "$__INIT_ENV_LOADED" ]; then |
There was a problem hiding this comment.
Should be ${__INIT_ENV_LOADED:-} to avoid unbound surprises.
| # Count interfaces with bInterfaceClass = 03 (HID) under /sys/bus/usb/devices | ||
| hid_iface_count=0 | ||
| log_info "=== USB HID device Detection ===" | ||
| hid_iface_count="$(cat /sys/bus/usb/devices/*/bInterfaceClass 2>/dev/null | grep -i '03' | wc -l)" |
There was a problem hiding this comment.
HID counting logic too loose.
- grep -i '03' matches any line containing 03 (rare but sloppy).
- cat | grep | wc pipeline can leave whitespace in wc output.
- Better: match exactly 03.
hid_iface_count="$(grep -h -x '03' /sys/bus/usb/devices/*/bInterfaceClass 2>/dev/null | wc -l | awk '{print $1}')"
| log_info "=== USB HID device Detection ===" | ||
| hid_iface_count="$(cat /sys/bus/usb/devices/*/bInterfaceClass 2>/dev/null | grep -i '03' | wc -l)" | ||
|
|
||
| printf "Number of HID interfaces found: $hid_iface_count" |
There was a problem hiding this comment.
use log_info
log_info "Number of HID interfaces found: $hid_iface_count"
| exit 1 | ||
| fi | ||
|
|
||
| log_info "-------------------Completed $TESTNAME Testcase----------------------------" |
There was a problem hiding this comment.
Remove it or move it before the final decision
| @@ -0,0 +1,37 @@ | |||
| ``` | |||
There was a problem hiding this comment.
SPDX header shouldn’t be in a fenced code block, our usual pattern is plain text at top (or as comments).
| @@ -0,0 +1,16 @@ | |||
| metadata: | |||
| name: usb-hid | |||
There was a problem hiding this comment.
usb-hid vs test folder/testname usb_hid. Prefer consistent naming.
| - REPO_PATH=$PWD | ||
| - cd Runner/suites/Kernel/Baseport/usb_hid | ||
| - ./run.sh || true | ||
| - $REPO_PATH/Runner/utils/send-to-lava.sh usb_hid.res || true |
There was a problem hiding this comment.
we can remove || true from this setup
2 participants
The shell script verifies the enumeration of USB Human Interface Devices connected to DUT.