Skip to content

Fix weston-simple-egl overlay detection for Adreno GLVND vendor JSON#312

Merged
abbajaj806 merged 1 commit intoqualcomm-linux:mainfrom
smuppand:graphics
Feb 24, 2026
Merged

Fix weston-simple-egl overlay detection for Adreno GLVND vendor JSON#312
abbajaj806 merged 1 commit intoqualcomm-linux:mainfrom
smuppand:graphics

Conversation

@smuppand
Copy link
Contributor

This PR fixes the build flavour detection logic in the weston-simple-egl test and also partially #310 where the build falvor detection is misleading.

Problem

  • The test classified builds as “overlay” only when a file matching:
    /usr/share/glvnd/egl_vendor.d/*EGL_adreno.json
    was present.
  • Some images use the GLVND vendor filename 10_adreno.json instead, so
    overlay builds were incorrectly reported as “base”.

Fix

  • Update overlay detection to scan common GLVND vendor directories:
    • /usr/share/glvnd/egl_vendor.d
    • /etc/glvnd/egl_vendor.d
  • Accept both naming styles:
    • adreno.json (e.g., 10_adreno.json)
    • EGL_adreno.json (e.g., 10_EGL_adreno.json)
  • Keep existing logging format, and improve the “base” message to reflect
    the broader detection.

…endor JSON

The test previously detected overlay builds only when a file matching
/usr/share/glvnd/egl_vendor.d/*EGL_adreno.json existed. Some images use
the GLVND vendor filename 10_adreno.json instead, causing overlay builds
to be misclassified as base.

Update detection to scan common GLVND vendor directories and accept both
*adreno*.json and *EGL_adreno*.json patterns. Log the detected vendor
JSON path when overlay is present.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit 3147945 into qualcomm-linux:main Feb 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants