Skip to content

Pull requests to main get no build validation #143

Description

Pull requests to resolute-qcom-devel are build-checked by premerge-pr.yml. Pull requests to main are not: nothing on main builds a kernel on pull_request.

Changes to main carry the wider blast radius. premerge-pr.yml and the nightly both call build-kernel.yml@main, so a broken workflow merged to main breaks every devel PR check and the next nightly. Recent CI changes have had to be validated by hand instead: #108 needed a temporary ref pin and a manual dispatch, and #129 and #141 were verified only through apt-get build-dep.

Proposal: a build-only check on pull requests to main, building resolute-qcom-devel with the PR's workflow and scripts. No distro-images dispatch and no S3 upload.

  • Call build-kernel.yml by local path rather than @main, so the PR's version is what runs.
  • Make the CI scripts ref an input defaulting to main, so the check can run the PR's scripts without loosening the default pin.
  • Limit to changes under .github/workflows/ and scripts/ so docs-only PRs skip it, and keep it non-required at first, since a path-skipped required check never reports.
  • Guard the job to same-repository pull requests. On pull_request the workflow definition comes from the PR itself, so this prevents accidental runs rather than enforcing anything; fork approval settings remain the boundary for the self-hosted runner.
  • Build the qcom flavour with dbgsym disabled, matching premerge-pr.yml.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions