Repository navigation
ci: add a build check for pull requests to main - #146
Open
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Open
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Conversation
Pull requests to resolute-qcom-devel are build-checked, but pull requests to main, which hold the CI every devel build runs, are not. premerge-pr.yml and the nightly both call build-kernel.yml@main, so a broken change there breaks every devel PR check and the next nightly with nothing having caught it first. premerge-main.yml builds resolute-qcom-devel with the PR's own build-kernel.yml, called by local path, and the PR's own scripts, through a new ci_scripts_ref input. That input defaults to main, so the schedule, workflow_dispatch and premerge-pr.yml runs resolve exactly as before. It builds the qcom flavour without dbgsym and uploads nothing. The workflow is deliberately not named "Pre-merge PR build": premerge-distro-validation.yml triggers on workflow_run of that exact name and would otherwise dispatch a distro image build for every pull request to main. It runs only when a PR touches .github/workflows/ or scripts/. The same-repository condition avoids accidental fork runs but is not a security boundary, since on pull_request the PR supplies the workflow; fork approval settings remain what gates the self-hosted runner. Closes #143 Signed-off-by: Bjordis Collaku <bcollaku@qti.qualcomm.com>
Bjordis Collaku (bjordiscollaku)
marked this pull request as ready for review
October 9, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
Pull requests to
mainget no build validation today, althoughpremerge-pr.ymland the nightly both runbuild-kernel.yml@main. This adds a build-only check for them.premerge-main.ymlbuildsresolute-qcom-develwith the PR's ownbuild-kernel.yml, called by local path, and the PR's own scripts, through a newci_scripts_refinput that defaults tomain. It builds theqcomflavour without dbgsym and uploads nothing..github/workflows/orscripts/.premerge-distro-validation.ymlmatches that name exactly and would otherwise dispatch a distro image build for every PR tomain.Existing callers are unchanged: the schedule,
workflow_dispatchandpremerge-pr.ymlall still check scripts out frommain.Validation
$/self-repository syntax is suppressed inline, because actionlint cannot parse that form yet and would lose the input check.Checkout CI scriptsfetchedrefs/pull/146/merge, the S3 upload was skipped, it built theqcomand indep packages (7.0.0-1014.17+qcom89.408a15c778ae), and no distro validation run was started.Notes
pull_requestthe PR supplies the workflow, so fork approval settings remain the boundary for the self-hosted runner.