Repository navigation
ci: run the config policy checks the build was skipping - #152
Draft
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Draft
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Bjordis Collaku (bjordiscollaku) wants to merge 1 commit into
Conversation
The build passed do_skip_checks=true, attributed to bindgen-0.65 being unavailable. bindgen 0.72.1 is installed; the flag was hiding two unrelated failures in the annotations check, both now fixed: Rust being disabled by the TARGET variable (#144) and CONFIG_QCOM_MEMORY_DUMP_V2 annotated as absent on resolute-qcom-devel (#145). Of the checks the flag controls, only two run in a binary build. The annotations check now passes for qcom and qcom-rt, verified with the prepare stage on Ubuntu 26.04 arm64. The staging module signature check runs even when skipped and already passes, 76 of 76 modules for both flavours in nightly run 37700985977. final-checks is only reached through insertchanges and never runs here. Drop the flag from the workflow and from the local build guide, so a config that does not match the annotations fails the build instead of shipping. This depends on the #145 fix being on resolute-qcom-devel, since devel builds run build-kernel.yml from main. Closes #136 Signed-off-by: Bjordis Collaku <bcollaku@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
Drops
do_skip_checks=truefrom the build and from the local build guide, so a config that does not match the annotations fails the build instead of shipping.The flag was attributed to bindgen-0.65 being unavailable. bindgen 0.72.1 is installed; the flag was hiding two unrelated annotation failures:
CONFIG_RUST_IS_AVAILABLE, fixed by ci: stop passing TARGET into the build container #150CONFIG_QCOM_MEMORY_DUMP_V2, fixed onresolute-qcom-develby UBUNTU: [Config] annotate QCOM_MEMORY_DUMP_V2 as n, not - #151What it re-enables. Of the checks the flag controls, only two run in a
binarybuild. The annotations check passes forqcomandqcom-rtwith both fixes in place, run with thepreparestage on Ubuntu 26.04 arm64. The staging module signature check runs even when skipped and already passes, 76 of 76 modules for both flavours in nightly run 37700985977.final-checksis only reached throughinsertchangesand never runs here.Merge order. Merge only after #151 is on
resolute-qcom-devel. Devel builds runbuild-kernel.yml@main, so landing this first would fail every devel PR check and the nightly.Stacked on #150.