ci: drop CLONE_PAT once repos go public#1103
Merged
Merged
Conversation
Once qualcomm/nexa-sdk and its submodules are public, anonymous clone needs no PAT, so GITHUB_TOKEN suffices for all source checkouts. Remove the CLONE_PAT token override from build/test/lint; GH_PAT stays only for dispatching geniex's publish-s3. Delete the CLONE_PAT secret after merge. Signed-off-by: RemiliaForever <remilia@koumakan.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the `CLONE_PAT` token override from all source checkouts in `_build-sdk`, `_build-cli`, `_build-docker`, `_test`, and `_lint` (8 sites).
Why
`CLONE_PAT` was introduced in #1102 so the submodule-recursive checkouts could authenticate independently of `GH_PAT` (which that PR repurposed for dispatching geniex's publish-s3). It is only needed while the repo and its submodules are private.
Once `qualcomm/nexa-sdk`, `geniex-qairt-plugin`, and `geniex-proc` are public, anonymous clone needs no PAT — the default `GITHUB_TOKEN` suffices for all source checkouts. `GH_PAT` stays in place solely for dispatching geniex's `chore/publish-s3`.
Merge order / follow-up