Skip to content

Conversation

@kartnema
Copy link
Contributor

No description provided.

#include "RestuneParser.h"

static void* extensionsLibHandle = nullptr;
#define MAX_EXTENSION_LIB_HANDLES 32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep 3 as default here and take it from property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict b/w loading extensions or reading properties first

For common Properties: Yes we can keep the value as an attribute in the common PropertiesConfig.yaml file and read from there.

However, fetching this value from custom PropertiesConfig.yaml (if override is provided) could result in circular logic, since we allow through the extension interface (plugins), the capability to the user to provide their own PropertiesConfig.yaml (kept in any arbitrary location), via the RESTUNE_REGISTER_CONFIG. To handle such scenarios we need to load the extension libs first, and that is what we are doing currently.
Example: https://github.com/qualcomm/userspace-resource-manager/blob/main/tests/Utils/Setup.cpp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep this property in common property file

@kartnema kartnema merged commit eaf0abd into qualcomm:main Jan 30, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants