-
Notifications
You must be signed in to change notification settings - Fork 17
Add support for loading multiple extension libs #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for loading multiple extension libs #152
Conversation
resource-tuner/init/RestuneInit.cpp
Outdated
| #include "RestuneParser.h" | ||
|
|
||
| static void* extensionsLibHandle = nullptr; | ||
| #define MAX_EXTENSION_LIB_HANDLES 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep 3 as default here and take it from property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a conflict b/w loading extensions or reading properties first
For common Properties: Yes we can keep the value as an attribute in the common PropertiesConfig.yaml file and read from there.
However, fetching this value from custom PropertiesConfig.yaml (if override is provided) could result in circular logic, since we allow through the extension interface (plugins), the capability to the user to provide their own PropertiesConfig.yaml (kept in any arbitrary location), via the RESTUNE_REGISTER_CONFIG. To handle such scenarios we need to load the extension libs first, and that is what we are doing currently.
Example: https://github.com/qualcomm/userspace-resource-manager/blob/main/tests/Utils/Setup.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep this property in common property file
No description provided.