Skip to content

Resolve Build Warnings #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajulup merged 1 commit into from
Jan 30, 2026
Merged

Resolve Build Warnings #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/Comm/Socket/SocketClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ int32_t SocketClient::initiateConnection() {
struct sockaddr_un addr;
memset(&addr, 0, sizeof(struct sockaddr_un));
addr.sun_family = AF_UNIX;
if(snprintf(addr.sun_path, UNIX_PATH_MAX, RESTUNE_SOCKET_PATH) >= UNIX_PATH_MAX) {
size_t written = snprintf(addr.sun_path, UNIX_PATH_MAX, RESTUNE_SOCKET_PATH);
if(written >= UNIX_PATH_MAX) {
LOGE("RESTUNE_SOCKET_CLIENT", "Socket path too long");
close(this->sockFd);
this->sockFd = -1;
Expand Down
3 changes: 1 addition & 2 deletions extensions/Include/Extensions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ class Extensions {
static PostProcessingCallback getPostProcessingCallback(const std::string& identifier);
};

#define CONCAT_IMPL(a, b) a##b
#define CONCAT(a, b) CONCAT_IMPL(a, b)
#define CONCAT(a, b) a ## b

/**
* \def URM_REGISTER_RES_APPLIER_CB(resCode, resourceApplierCallback)
Expand Down
2 changes: 1 addition & 1 deletion resource-tuner/core/Server/Include/RestuneListener.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class SocketServer : public ServerEndpoint {
ServerOnlineCheckCallback mServerOnlineCheckCb,
MessageReceivedCallback mMessageRecvCb);

~SocketServer();
virtual ~SocketServer();

virtual int32_t ListenForClientRequests();
virtual int32_t closeConnection();
Expand Down
3 changes: 2 additions & 1 deletion resource-tuner/core/Server/RestuneListener.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ int32_t SocketServer::ListenForClientRequests() {
struct sockaddr_un addr;
memset(&addr, 0, sizeof(sockaddr_un));
addr.sun_family = AF_UNIX;
if(snprintf(addr.sun_path, UNIX_PATH_MAX, RESTUNE_SOCKET_PATH) >= UNIX_PATH_MAX) {
size_t written = snprintf(addr.sun_path, UNIX_PATH_MAX, RESTUNE_SOCKET_PATH);
if(written >= UNIX_PATH_MAX) {
LOGE("RESTUNE_SOCKET_SERVER", "Socket path too long");
close(this->sockFd);
this->sockFd = -1;
Expand Down
4 changes: 2 additions & 2 deletions resource-tuner/core/TargetRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ void TargetRegistry::generatePolicyBasedMapping(std::vector<std::string>& policy

// Now, Create the Logical to Physical Mappings
// Note the Clusters are arranged in increasing order of Capacities
for(int32_t i = 0; i < clusterConfigs.size(); i++) {
for(size_t i = 0; i < clusterConfigs.size(); i++) {
this->mLogicalToPhysicalClusterMapping[i] = clusterConfigs[i].second.second->mPhysicalID;
}
}
Expand Down Expand Up @@ -235,7 +235,7 @@ void TargetRegistry::getClusterIdBasedMapping() {

// Now, Create the Logical to Physical Mappings
// Note the Clusters are arranged in increasing order of Capacities
for(int32_t i = 0; i < clusterConfigs.size(); i++) {
for(size_t i = 0; i < clusterConfigs.size(); i++) {
this->mLogicalToPhysicalClusterMapping[i] = clusterConfigs[i].second->mPhysicalID;
}
}
Expand Down
4 changes: 2 additions & 2 deletions resource-tuner/init/RestuneParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ ErrCode RestuneParser::parseSignalConfigYamlNode(const std::string& filePath, in
rc = resourceBuilder->setNumValues(resValues.size());
}

for(int32_t idx = 0; idx < resValues.size(); idx++) {
for(size_t idx = 0; idx < resValues.size(); idx++) {
if(RC_IS_OK(rc)) {
rc = resourceBuilder->addValue(idx, resValues[idx]);
}
Expand Down Expand Up @@ -971,7 +971,7 @@ ErrCode RestuneParser::parsePerAppConfigYamlNode(const std::string& filePath) {
return RC_YAML_INVALID_SYNTAX;
}
}
for(int32_t i = 0; i < itemArray.size(); i++) {
for(size_t i = 0; i < itemArray.size(); i++) {
if(RC_IS_OK(rc)) {
rc = appConfigBuider->addSigCode(i, itemArray[i]);
if(RC_IS_NOTOK(rc)) {
Expand Down
Loading