Conversation
Member
varunsinghal-Qualcomm
commented
Jan 29, 2026
varunsinghal-Qualcomm
commented
- Improve UNIX socket path length validation in client and server
- Use size_t for vector loop indices to avoid type issues
- Make SocketServer destructor virtual for safe cleanup
- Simplify CONCAT macro definition
varunsinghal-Qualcomm
force-pushed
the
main
branch
from
20cdcd1 to
40eeac4
Compare
rajulup
reviewed
Jan 29, 2026
client/Comm/Socket/SocketClient.cpp
Outdated
| memset(&addr, 0, sizeof(struct sockaddr_un)); | ||
| addr.sun_family = AF_UNIX; | ||
| if(snprintf(addr.sun_path, UNIX_PATH_MAX, RESTUNE_SOCKET_PATH) >= UNIX_PATH_MAX) { | ||
| int written = snprintf(addr.sun_path, UNIX_PATH_MAX, RESTUNE_SOCKET_PATH); |
Contributor
There was a problem hiding this comment.
lets declare written as size_t
rajulup
requested changes
Jan 29, 2026
| addr.sun_family = AF_UNIX; | ||
| if(snprintf(addr.sun_path, UNIX_PATH_MAX, RESTUNE_SOCKET_PATH) >= UNIX_PATH_MAX) { | ||
| int written = snprintf(addr.sun_path, UNIX_PATH_MAX, RESTUNE_SOCKET_PATH); | ||
| if(written < 0 || static_cast<size_t>(written) >= UNIX_PATH_MAX) { |
Contributor
There was a problem hiding this comment.
lets declare written as size_t
Signed-off-by: varusing <varusing@qti.qualcomm.com>
varunsinghal-Qualcomm
force-pushed
the
main
branch
from
40eeac4 to
0981056
Compare
kartnema
approved these changes
Jan 30, 2026
rajulup
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.