Skip to content

Conversation

@simamta
Copy link
Contributor

@simamta simamta commented Jan 29, 2026

No description provided.

Comment on lines +184 to +185
spawn_short_process();
std::this_thread::sleep_for(std::chrono::milliseconds(300));

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function Cgroups_FocusedSliceMove_XFail_impl is unreachable (
Cgroups_FocusedSliceMove_XFail_reg
must be removed at the same time)
}

MT_TEST(Classifier, Queue_BackPressure, "integration") {
for (int i = 0; i < 50; ++i) spawn_short_process();

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function Classifier_Netlink_RobustToEINTR_impl is unreachable (
Classifier_Netlink_RobustToEINTR_reg
must be removed at the same time)
std::this_thread::sleep_for(std::chrono::milliseconds(kSettleMs));
const std::string logs = read_journal_last_seconds(120);
MT_REQUIRE(ctx, contains_line(logs, kInitEnter));
MT_REQUIRE(ctx, contains_line(logs, kInitOk2)); // listening for events

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function Classifier_Queue_BackPressure_impl is unreachable (
Classifier_Queue_BackPressure_reg
must be removed at the same time)
|| logs.find("Ignoring process: sed") != std::string::npos);
}

MT_TEST_XFAIL(Signals, Config_Parsing_XFail, "integration",

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function Classifier_Terminate_Restart_Clean_impl is unreachable (
Classifier_Terminate_Restart_Clean_reg
must be removed at the same time)
MT_REQUIRE(ctx, logs.find("Signal Parsing Failed with Error: stol") != std::string::npos);
}

MT_TEST_XFAIL(Extractor, CSVDump_XFail, "integration",

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function Classifier_IgnoreList_Basic_impl is unreachable (
Classifier_IgnoreList_Basic_reg
must be removed at the same time)
Copy link
Contributor

@kartnema kartnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general question @jpagadal @simamta
Will the Kernel Configs needed for classifier to listen on netlink be available in the runner environment where our tests will run?

@simamta
Copy link
Contributor Author

simamta commented Jan 29, 2026

@kartnema yes it is enabled on devcompute where i tested

@jpagadal
Copy link
Contributor

One general question @jpagadal @simamta Will the Kernel Configs needed for classifier to listen on netlink be available in the runner environment where our tests will run?

Yes @kartnema, runners, devcompute (Ubuntu 24.04) have these configs enabled.
Even in our PR runs we have enabled these configs and they are passing.

@jpagadal
Copy link
Contributor

@simamta
Can you also check the warnings from CodeQL like - Static function spawn_short_process is unreachable?

Comment on lines +248 to +249
// Look for *either* pruned or unfiltered CSVs (simple probe)
auto r = run_cmd("bash -lc 'ls /var/cache/pruned/*_proc_info* /var/cache/unfiltered/*_proc_info* 2>/dev/null | head -n1'");

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function Signals_Config_Parsing_XFail_impl is unreachable (
Signals_Config_Parsing_XFail_reg
must be removed at the same time)
@kartnema kartnema marked this pull request as draft February 1, 2026 05:36
@kartnema kartnema assigned kartnema and unassigned kartnema Feb 1, 2026
@kartnema kartnema added the not-ready PR requires further changes / enhancements, please don't merge. label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-ready PR requires further changes / enhancements, please don't merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants