Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch vsce to work with yarn #1162

Closed
berekuk opened this issue Sep 19, 2022 · 0 comments · Fixed by #1232
Closed

Patch vsce to work with yarn #1162

berekuk opened this issue Sep 19, 2022 · 0 comments · Fixed by #1232
Labels
Devops Pertaining to CI and other scripting infra, building and deploying VS Code extension

Comments

@berekuk
Copy link
Collaborator

berekuk commented Sep 19, 2022

vsce (tool for building VS Code extensions) doesn't work well with yarn; details in microsoft/vscode-vsce#300.

We currently use https://www.npmjs.com/package/vsce-yarn-patch fork, but it's 3 years old and doesn't support modern features, e.g. --pre-release flag. So we currently can't upload prerelease extensions to the VS Code marketplace because of this.

The patch is pretty tiny: nlunets/vscode-vsce@master...bestander:vscode-vsce:master, so hopefully it shouldn't be hard to reproduce on top of the modern vsce.
@berekuk berekuk added Devops Pertaining to CI and other scripting infra, building and deploying VS Code extension labels Sep 19, 2022
@berekuk berekuk added this to Overview Oct 3, 2022
@berekuk berekuk moved this to 🆕 To prioritize in Overview Oct 3, 2022
@cab404 cab404 mentioned this issue Oct 8, 2022
Merged
cab404 added a commit to cab404/squiggle that referenced this issue Oct 8, 2022
@cab404
vscode-ext: move to esbuild bundling, cleanup
a13cd44 
This removes node_modules from dependencies all together fixing long
time issue with yarn putting only a subset of dependencies in the
extension source tree.

It as well makes extension footprint 15x smaller. (down to 2.3Mb)

Kinda fixes quantified-uncertainty#1162? It actually un-patches vsce though — it really is not
an issue it should be solving :D
cab404 added a commit to cab404/squiggle that referenced this issue Oct 8, 2022
@cab404
vscode-ext: move to esbuild bundling, cleanup
bb6c680 
This removes node_modules from dependencies all together fixing long
time issue with yarn putting only a subset of dependencies in the
extension source tree.

It as well makes extension footprint 15x smaller. (down to 2.3Mb)

Kinda fixes quantified-uncertainty#1162? It actually un-patches vsce though — it really is not
an issue it should be solving :D
cab404 added a commit to cab404/squiggle that referenced this issue Oct 8, 2022
@cab404
vscode-ext: move to esbuild bundling, cleanup
13a54f3 
This removes node_modules from dependencies all together fixing long
time issue with yarn putting only a subset of dependencies in the
extension source tree.

It as well makes extension footprint 15x smaller. (down to 2.3Mb)

Kinda fixes quantified-uncertainty#1162? It actually un-patches vsce though — it really is not
an issue it should be solving :D
@berekuk berekuk removed this from Overview Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Devops Pertaining to CI and other scripting infra, building and deploying VS Code extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vscode-ext: move to esbuild bundling, cleanup cab404/squiggle
1 participant
@berekuk