vscode-ext: move to esbuild bundling, cleanup #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cab404
requested review from
quinn-dougherty,
Hazelfire,
berekuk and
OAGr
as code owners
|
@cab404 is attempting to deploy a commit to the Quantified Uncertainty Team on Vercel. A member of the Team first needs to authorize it. |
cab404
force-pushed
the
cab/esbuild-vsix
branch
from
a13cd44 to
bb6c680
Compare
This removes node_modules from dependencies all together fixing long time issue with yarn putting only a subset of dependencies in the extension source tree. It as well makes extension footprint 15x smaller. (down to 2.3Mb) Kinda fixes quantified-uncertainty#1162? It actually un-patches vsce though — it really is not an issue it should be solving :D
cab404
force-pushed
the
cab/esbuild-vsix
branch
from
bb6c680 to
13a54f3
Compare
berekuk
reviewed
Oct 8, 2022
cab404
requested review from
berekuk
and removed request for
OAGr,
Hazelfire and
quinn-dougherty
cab404
force-pushed
the
cab/esbuild-vsix
branch
from
7d78024 to
28e944d
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
berekuk
requested changes
Oct 8, 2022
berekuk
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes node_modules from dependencies all together,fixing long time issue with yarn putting only a subset of dependencies in the extension source tree.
It as well makes extension footprint 15x smaller. (down to 2.3Mb)
Kinda fixes #1162? It actually un-patches vsce though — it really is not an issue it should be solving :D