Replace type_workarounds.NotImplementedType with types.NotImplementedType #6790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tedType - Updated code to use Python 3.10's built-in types.NotImplementedType, removing the need for the type_workarounds module. This change simplifies the codebase by relying on standard types, allowing us to delete the now-redundant type_workarounds.py file.
pavoljuhas
reviewed
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6790 +/- ##
==========================================
- Coverage 97.85% 97.84% -0.01%
==========================================
Files 1085 1084 -1
Lines 93592 93590 -2
==========================================
- Hits 91582 91577 -5
- Misses 2010 2013 +3 ☔ View full report in Codecov by Sentry. |
|
For a faster testing consider setting up a Python development environment following After that running |
|
@pavoljuhas, All checks have passed |
No change in code function
pavoljuhas
approved these changes
Nov 13, 2024
|
Thanks, @pavoljuhas, for reviewing and merging the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced type_workarounds.NotImplementedType with types.NotImplementedType
Updated code to use Python 3.10's built-in types.NotImplementedType, removing the need for the type_workarounds module.
This change simplifies
the codebase by relying on standard types, allowing us to delete the now-redundant type_workarounds.py file.
Fixes #6775