update parallel XEB methods to support circuits instead of single gates #6940
+210
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
requested review from
mrwojtek,
vtomole and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6940 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 1084 1084
Lines 94408 94447 +39
=======================================
+ Hits 92393 92432 +39
Misses 2015 2015 ☔ View full report in Codecov by Sentry. |
eliottrosenberg
requested changes
Jan 14, 2025
| @@ -403,6 +403,7 @@ def parallel_xeb_workflow( | |||
| pool: Optional['multiprocessing.pool.Pool'] = None, | |||
| batch_size: int = 9, | |||
| tags: Sequence[Any] = (), | |||
| entangling_circuit_or_op: Optional[Union['cirq.AbstractCircuit', 'cirq.Operation']] = None, | |||
There was a problem hiding this comment.
Actually, in order to do parallel XEB, we will want to be able to input something like a set of circuits (that each act on two qubits) or a dictionary from pairs to circuits because, for example, we may have different z-phase corrections on different pairs of qubits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel XEB methods assume they run on specific gate objects ... however some operations need to be represented using a circuit
to run XEB on a circuit call the desired method with
entangling_circuit_or_op=...