Add a .shellcheckrc file #7079
Draft
Add a .shellcheckrc file #7079
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a config file for .shellcheckrc, and sets a few optional flags to try to make shellcheck slightly more thorough.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7079 +/- ##
==========================================
- Coverage 98.16% 98.16% -0.01%
==========================================
Files 1093 1093
Lines 95456 95456
==========================================
- Hits 93701 93700 -1
- Misses 1755 1756 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhucka
added a commit
to mhucka/Cirq
that referenced
this pull request
Feb 23, 2025
Using the added `.shellcheckrc` options of PR quantumlib#7079, the `shellcheck` program flagged a couple of places where the effects of the `set -e` at the beginning of this script would not have the expected effect.
mhucka
added
area/cleancode
kind/health
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a config file for .shellcheckrc, and sets a few optional flags to try to make shellcheck slightly more thorough.