Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sweep_must_pass in gauge_compiling tests #7124

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

babacry
Copy link
Collaborator

@babacry babacry commented Mar 6, 2025

sweep_must_pass var in test class was used during the multi-pr implementations of as_sweep for different gauges. Now all the gauges have been supported by as_sweep, so, we can safely remove the flag here as by default sweep is tested for gauges.

@CirqBot CirqBot added the size: S 10< lines changed <50 label Mar 6, 2025
@babacry babacry changed the title Remove sweep_must_pass in gauge_compiling tests. Remove sweep_must_pass in gauge_compiling tests Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (aa2b025) to head (0ea6483).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7124      +/-   ##
==========================================
- Coverage   98.16%   98.16%   -0.01%     
==========================================
  Files        1093     1093              
  Lines       95432    95420      -12     
==========================================
- Hits        93677    93665      -12     
  Misses       1755     1755              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babacry babacry marked this pull request as ready for review March 6, 2025 21:31
@babacry babacry requested review from vtomole and a team as code owners March 6, 2025 21:31
@babacry babacry requested a review from fdmalone March 6, 2025 21:31
@NoureldinYosri
Copy link
Collaborator

@babacry I would leave it but change its default to True

@babacry
Copy link
Collaborator Author

babacry commented Mar 6, 2025

@NoureldinYosri , the variable sweep_must_pass is already deleted in test utils right now, meaning that all the gauges' sweeps are already tested no matter whether the variable is set, the deleted lines here are lingering not useful lines. Though I can revive the variable to control if we want to test sweep.

@NoureldinYosri NoureldinYosri added this pull request to the merge queue Mar 6, 2025
Merged via the queue into quantumlib:main with commit 78d30e7 Mar 6, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants