Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes of linalg.decompositions #7128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

babacry
Copy link
Collaborator

@babacry babacry commented Mar 7, 2025

  • Remove unused code.
  • Actual raise in kron 4x4 to 2x2s (raise was in docstring, but not actualized). Update related tests as well.
  • Other nit fixes.

@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (78d30e7) to head (45db532).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7128   +/-   ##
=======================================
  Coverage   98.16%   98.17%           
=======================================
  Files        1093     1093           
  Lines       95420    95441   +21     
=======================================
+ Hits        93665    93695   +30     
+ Misses       1755     1746    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babacry babacry changed the title Small fixes of linalg.decomposition Small fixes of linalg.decompositions Mar 8, 2025
@babacry babacry marked this pull request as ready for review March 8, 2025 01:41
@babacry babacry requested review from vtomole and a team as code owners March 8, 2025 01:41
@babacry babacry requested a review from dabacon March 8, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants