Micro-optimization for Gateset containment #7692
Open
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Oct 2, 2025
dstrain115
commented
- Check gate families with tags before doing instance GateFamily checks.
- This change will check cirq.GateFamily(cirq.ZPowGate, tags_to_accept=[PhysicalZ()]) before instance gate families.
- We generally want to avoid checking instance gate families if at all possible, since they can call protocols.equal_up_to_global_phase which is quite slow.
- Check gate families with tags before doing instance GateFamily checks. - This change will check cirq.GateFamily(cirq.ZPowGate, tags_to_accept=[PhysicalZ()]) before instance gate families. - We generally want to avoid checking instance gate families if at all possible, since they can call protocols.equal_up_to_global_phase which is quite slow.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7692 +/- ##
========================================
Coverage 99.38% 99.38%
========================================
Files 1089 1089
Lines 97414 97535 +121
========================================
+ Hits 96812 96934 +122
+ Misses 602 601 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
reviewed
Oct 7, 2025
| # Lastly, do a final exhaustive check to make sure this is not equivalent | ||
| # to another type of gate. This will catch things like: | ||
| # cirq.XPowGate(exponent=0) in cirq.GateFamily(cirq.I) | ||
| return any(item in gate_family for gate_family in self._gates) |
There was a problem hiding this comment.
We should probably do self._gates.difference(self._gate_families_with_tags) because gfwt are already checked on line 451.
pavoljuhas
reviewed
Oct 7, 2025
Comment on lines
+332
to
+334
| print(gateset._gate_families_with_tags) | ||
| for g in gateset.gates: | ||
| print(f"{g} {gate in g}") |
pavoljuhas
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.