Skip to content

Conversation

dstrain115
Copy link
Collaborator

  • Slightly optimize validation to avoid calling op.qubits several
    times. This also avoids an isinstance check.
  • Change instance GateFamily for cirq.I into a type GateFamily for
    IdentityGate which is faster and more general.
  • Also add ignore_global_phase=False versions of gatesets.
  • These gatesets are faster since they do not perform unitary
    decomposition to check equivalency.
  • Internal versions will switch to these versions once this change
    propagates.

- Slightly optimize validation to avoid calling op.qubits several
times.   This also avoids an isinstance check.
- Change instance GateFamily for cirq.I into a type GateFamily for
IdentityGate which is faster and more general.
- Also add ignore_global_phase=False versions of gatesets.
- These gatesets are faster since they do not perform unitary
decomposition to check equivalency.
- Internal versions will switch to these versions once this change
propagates.
@dstrain115 dstrain115 requested review from wcourtney, vtomole, verult and a team as code owners October 3, 2025 17:36
@github-actions github-actions bot added the size: M 50< lines changed <250 label Oct 3, 2025
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (3317377) to head (a3113f3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7693    +/-   ##
========================================
  Coverage   99.38%   99.38%            
========================================
  Files        1089     1089            
  Lines       97414    97531   +117     
========================================
+ Hits        96812    96930   +118     
+ Misses        602      601     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant