Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: grid can be set per page #1339

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

mcanouil
Copy link
Contributor

@mcanouil mcanouil changed the base branch from main to prerelease September 17, 2024 19:22
@cderv
Copy link
Collaborator

cderv commented Oct 3, 2024

/deploy-preview

Copy link
Contributor

github-actions bot commented Oct 3, 2024

🚀 Deployed on https://deploy-preview-1339.quarto.org

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Other part of this doc should be updated then right ?
Like https://deploy-preview-1339.quarto.org/docs/output-formats/page-layout.html#grid-customization
image

Possibly that is the only missing change.

@mcanouil
Copy link
Contributor Author

mcanouil commented Oct 4, 2024

Well, I thought about changing it here as well, but I thought of it as an example. So to me it make sense to be a bit specific. It also makes sense to keep it general in this part which is kind of a summary.
What do you think?

@mcanouil
Copy link
Contributor Author

mcanouil commented Oct 4, 2024

I made the change.

@cderv
Copy link
Collaborator

cderv commented Oct 4, 2024

Well, I thought about changing it here as well, but I thought of it as an example. So to me it make sense to be a bit specific. It also makes sense to keep it general in this part which is kind of a summary.

Yeah makes sense - you're right about this. I'll revert and merge thanks !

@cderv cderv merged commit 4309159 into quarto-dev:prerelease Oct 4, 2024
3 checks passed
@mcanouil mcanouil deleted the docs/grid-page branch October 4, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants