Add allowIncomplete to runtime.executeCode() (#664)

* Add `allowIncomplete` to `runtime.executeCode()` * Update changelog
quarto-dev · Feb 18, 2025 · 1375251 · 1375251
1 parent 46c6d38
commit 1375251
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/apps/vscode/CHANGELOG.md b/apps/vscode/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 1.119.0 (unreleased)
 
 - Use `QUARTO_VISUAL_EDITOR_CONFIRMED` > `PW_TEST` > `CI` to bypass (`true`) or force (`false`) the Visual Editor confirmation dialogue (<https://github.com/quarto-dev/quarto/pull/654>).
+- Fix behavior in Positron when running a cell containing invalid/incomplete code (<https://github.com/quarto-dev/quarto/pull/664>).
 
 ## 1.118.0 (Release on 2024-11-26)
 

diff --git a/apps/vscode/src/@types/hooks.d.ts b/apps/vscode/src/@types/hooks.d.ts
@@ -16,7 +16,8 @@ declare module 'positron' {
 		executeCode(
 			languageId: string,
 			code: string,
-			focus: boolean
+			focus: boolean,
+			allowIncomplete: boolean
 		): Thenable<boolean>;
 	}
 

diff --git a/apps/vscode/src/host/hooks.ts b/apps/vscode/src/host/hooks.ts
@@ -74,7 +74,7 @@ export function hooksExtensionHost(): ExtensionHost {
               // Our callback executes each block sequentially
               const callback = async () => {
                 for (const block of blocks) {
-                  await runtime.executeCode(language, block, false);
+                  await runtime.executeCode(language, block, false, true);
                 }
               }