-
Notifications
You must be signed in to change notification settings - Fork 8
chore(nodejs): extract transport and buffer from sender, add back support for core http #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2025
puzpuzpuz
reviewed
Jul 29, 2025
puzpuzpuz
reviewed
Jul 29, 2025
puzpuzpuz
approved these changes
Jul 31, 2025
puzpuzpuz
reviewed
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting the transport layer from
Sender
, and introducing theSenderTransport
interface with different implementations:http
module with ILP over HTTPundici
module with ILP over HTTPAlso extracting the buffer from
Sender
into a classSenderBuffer
.Now the
Sender
is mostly just wiring between a transport and a buffer, and responsible only for auto flushing.In fact, you could create your own transport and buffer, and use them without a
Sender
if you are calling flush() manually.You could also create your own pools of buffers and transports, the transports could be even different types, and just flush your buffers when needed using one of the transports from the pool.
Also refactored and improved tests.
Introduced more types, such as Logger, ExtraOptions, TimestampUnit and MockConfig.
Fixed
any
andunknown
type warnings.