Skip to content

fix(web-console): use correct query for resuming WAL for a materialized view #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2025
Merged

fix(web-console): use correct query for resuming WAL for a materialized view #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd76559
fix(web-console): use correct query for resuming WAL for a materializ…
emrberk Jun 18, 2025
0de0275
update title
emrberk Jun 18, 2025
db4cc9b
Merge remote-tracking branch 'origin/main' into fix/mat-view-resume-wal
glasstiger Jun 30, 2025
4d55181
update submodule
glasstiger Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions packages/browser-tests/cypress/integration/console/schema.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,38 @@ describe("materialized views", () => {
}
});

it("should resume WAL for a materialized view", () => {
cy.getByDataHook("schema-row-error-icon").should("not.exist");
cy.typeQuery(
"ALTER MATERIALIZED VIEW btc_trades_mv SUSPEND WAL WITH 24, 'Too many open files';"
)
.clickRun()
.clearEditor();

cy.refreshSchema();
cy.expandMatViews();
cy.getByDataHook("schema-row-error-icon").should("be.visible");
cy.getByDataHook("schema-filter-suspended-button").should("contain", "1");

cy.getByDataHook("schema-matview-title")
.contains("btc_trades_mv")
.rightclick();
cy.getByDataHook("table-context-menu-resume-wal")
.should("not.be.disabled")
.click();

cy.getByDataHook("schema-suspension-dialog").should(
"have.attr",
"data-table-name",
"btc_trades_mv"
);
cy.getByDataHook("schema-suspension-dialog-restart-transaction").click();
cy.getByDataHook("schema-suspension-dialog-dismiss").click();
cy.getByDataHook("schema-suspension-dialog").should("not.exist");
cy.getByDataHook("schema-filter-suspended-button").should("not.exist");
cy.getByDataHook("schema-row-error-icon").should("not.exist");
});

it("should show a warning icon and tooltip when the view is invalidated", () => {
cy.intercept({
method: "GET",
Expand Down
2 changes: 1 addition & 1 deletion packages/browser-tests/questdb
Open in desktop
Submodule questdb updated 44 files
+3 −2 ci/templates/start-self-hosted-job.yml
+3 −3 core/rust/qdb-core/src/byte_util.rs
+5 −5 core/rust/qdb-core/src/col_driver/array.rs
+2 −2 core/rust/qdb-core/src/col_driver/binary.rs
+4 −4 core/rust/qdb-core/src/col_driver/primitives.rs
+3 −3 core/rust/qdb-core/src/col_driver/string.rs
+5 −5 core/rust/qdb-core/src/col_driver/varchar.rs
+7 −7 core/rust/qdb-core/src/error.rs
+5 −0 core/src/main/java/io/questdb/cairo/sql/Function.java
+1 −1 core/src/main/java/io/questdb/griffin/FunctionParser.java
+7 −0 core/src/main/java/io/questdb/griffin/SqlException.java
+3 −0 core/src/main/java/io/questdb/griffin/engine/functions/constants/DoubleConstant.java
+1 −0 core/src/main/java/io/questdb/griffin/engine/functions/constants/LongConstant.java
+99 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/AbstractGenerateSeriesRecordCursorFactory.java
+46 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesDoubleDefaultFunctionFactory.java
+45 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesDoubleFunctionFactory.java
+146 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesDoubleRecordCursorFactory.java
+47 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesLongDefaultFunctionFactory.java
+47 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesLongFunctionFactory.java
+154 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesLongRecordCursorFactory.java
+57 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesTimestampLongFunctionFactory.java
+170 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesTimestampRecordCursorFactory.java
+57 −0 core/src/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesTimestampStringFunctionFactory.java
+410 −0 ...rc/main/java/io/questdb/griffin/engine/functions/date/GenerateSeriesTimestampStringRecordCursorFactory.java
+27 −26 core/src/main/java/io/questdb/griffin/engine/functions/date/TimestampAddFunctionFactory.java
+163 −0 core/src/main/java/io/questdb/griffin/engine/functions/groupby/FirstArrayGroupByFunction.java
+55 −0 core/src/main/java/io/questdb/griffin/engine/functions/groupby/FirstArrayGroupByFunctionFactory.java
+15 −9 core/src/main/java/io/questdb/griffin/engine/functions/window/LastValueDoubleWindowFunctionFactory.java
+4 −0 core/src/main/java/io/questdb/griffin/engine/groupby/SampleByFillValueNotKeyedRecordCursor.java
+6 −0 core/src/main/java/io/questdb/griffin/engine/groupby/SimpleMapValue.java
+7 −0 core/src/main/java/io/questdb/griffin/engine/groupby/SimpleMapValuePeeker.java
+65 −18 core/src/main/java/io/questdb/std/SimpleAssociativeCache.java
+14 −3 core/src/test/java/io/questdb/test/AbstractCairoTest.java
+4 −1 core/src/test/java/io/questdb/test/ServerMainQueryTimeoutTest.java
+51 −0 core/src/test/java/io/questdb/test/cairo/ArrayTest.java
+81 −0 core/src/test/java/io/questdb/test/cairo/fuzz/ParallelGroupByFuzzTest.java
+3 −14 core/src/test/java/io/questdb/test/cutlass/http/RetryIODispatcherTest.java
+962 −0 core/src/test/java/io/questdb/test/griffin/engine/functions/date/GenerateSeriesFunctionFactoryTest.java
+4 −6 core/src/test/java/io/questdb/test/griffin/engine/functions/date/TimestampAddFunctionFactoryTest.java
+4 −4 ...rc/test/java/io/questdb/test/griffin/engine/functions/date/TimestampAddWithTimezoneFunctionFactoryTest.java
+0 −381 core/src/test/java/io/questdb/test/griffin/engine/groupby/SampleByBugfixTest.java
+352 −0 core/src/test/java/io/questdb/test/griffin/engine/groupby/SampleByTest.java
+21 −5 core/src/test/java/io/questdb/test/griffin/engine/window/WindowFunctionTest.java
+62 −0 core/src/test/java/io/questdb/test/std/AssociativeCacheTest.java
7 changes: 5 additions & 2 deletions packages/web-console/src/scenes/Schema/SuspensionDialog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,15 @@ const GENERIC_ERROR_TEXT = "Error restarting transaction"
type Props = {
walTableData: QuestDB.WalTable
open: boolean
kind: "table" | "matview"
onOpenChange: (open: boolean) => void
}

export const SuspensionDialog = ({
walTableData,
open,
onOpenChange,
kind,
}: Props) => {
const { quest } = useContext(QuestContext)
const [isSubmitting, setIsSubmitting] = useState(false)
Expand All @@ -93,9 +95,10 @@ export const SuspensionDialog = ({
const handleSubmit = async (values: FormValues) => {
setIsSubmitting(true)
setError(undefined)
const queryStart = `ALTER ${kind === "matview" ? "MATERIALIZED VIEW" : "TABLE"}`
try {
const response = await quest.query(
`ALTER TABLE ${walTableData.name} RESUME WAL${
`${queryStart} ${walTableData.name} RESUME WAL${
values.resume_transaction_id
? ` FROM TRANSACTION ${values.resume_transaction_id}`
: ""
Expand Down Expand Up @@ -148,7 +151,7 @@ export const SuspensionDialog = ({
<Dialog.Title>
<Box>
<Table size={20} color="#FF5555" />
Table is suspended: {walTableData.name}
{kind === "table" ? "Table" : "Materialized view"} is suspended: {walTableData.name}
</Box>
</Dialog.Title>

Expand Down
3 changes: 2 additions & 1 deletion packages/web-console/src/scenes/Schema/VirtualTables/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ const VirtualTables: FC<VirtualTablesProps> = ({
{item.walTableData?.suspended && (
<SuspensionDialog
walTableData={item.walTableData}
kind={item.kind}
open={openedSuspensionDialog === item.id}
onOpenChange={(isOpen) => {
setOpenedSuspensionDialog(isOpen ? item.id : null)
Expand All @@ -405,7 +406,7 @@ const VirtualTables: FC<VirtualTablesProps> = ({
{item.walTableData?.suspended && (
<MenuItem
data-hook="table-context-menu-resume-wal"
onClick={() => setOpenedSuspensionDialog(item.id)}
onClick={() => setTimeout(() => setOpenedSuspensionDialog(item.id))}
icon={<Restart size={14} />}
>
Resume WAL
Expand Down