Skip to content

Fixed deprecation warnings on substr and explode functions. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed deprecation warnings on substr and explode functions. #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UserInQueueService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ private function getQueryString(

private function generateRedirectUrl($queueDomain, $uriPath, $query)
{
if (substr($queueDomain, -1) !== "/")
if (substr($queueDomain ?? '', -1) !== "/")
$queueDomain = $queueDomain . "/";

return "https://" . $queueDomain . $uriPath . "?" . $query;
Expand Down
4 changes: 2 additions & 2 deletions UserInQueueStateCookieRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ private function createCookieValue($eventId, $queueId, $fixedCookieValidityMinut

private function getCookieNameValueMap($cookieValue) {
$result = array();
$cookieNameValues = explode("&", $cookieValue);
$cookieNameValues = explode("&", $cookieValue ?? '');
$length = count($cookieNameValues);

for ($i = 0; $i < $length; ++$i) {
$arr = explode("=", $cookieNameValues[$i]);
$arr = explode("=", $cookieNameValues[$i] ?? '');
Copy link

@crishoj crishoj Sep 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest keeping 4 spaces as indentation, as seems to be the convention here

if (count($arr) == 2) {
$result[$arr[0]] = $arr[1];
}
Expand Down